New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.x iZip issues fixed #168

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
2 participants
@mschmieder
Contributor

mschmieder commented May 9, 2017

Hello,

I fixed an issue with python3.x that prevented to create html reports due to missing 'iZip' function in itertools. gcovr now uses 'zip' when running with python 3.x directly

fixed issue with python3.x that prevented to create html reports due …
…to missing 'iZip' function in itertools. gcvr now uses 'zip' when running with python 3.x directly
@latk

latk approved these changes Dec 27, 2017

@latk latk merged commit 06f065f into gcovr:master Jan 6, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@latk latk removed the needs review label Jan 6, 2018

latk added a commit to latk/gcovr that referenced this pull request Jan 6, 2018

fix HTML tests
The HTML tests are naturally rather fragile, since lots of CSS is copied
into every file. However, they are quite valuable as they exercise
important code paths. For example, this would have found issues gcovr#163
or gcovr#168. By enabling these tests, we can avoid such problems in the
future.

Summary of changes:

**`scripts/gcovr`:**
removed some trailing whitespace in the HTML template.

**`gcovr/tests/test_gcovr.py`:**
normalize HTML files so that they can be compared. In particular, we
remove the exact version string, and the report creation date.

**`gcovr/tests/*/reference/coverage.html`:**
update the HTML files to match the current structure. This is mostly
removing trailing whitespace, and tracking changes to the CSS. If there
was some discrepancy in the content, the TXT and XML references were
assumed to be up to date and fresh values taken from there.

**`gcovr/tests/linked/reference/coverage.html`:**
update as with the other tests. However, this exposed significant
changes to the path name handling. Commit 1cc987a changed
`commonprefix()` to `commonpath()` to figure out better path names. This
function is used only by the HTML test, which therefore reports physical
paths. The HTML reference has been updated to use physical paths. E.g.
since the test case is constructed on the fly from the “nested” test,
the source root dir is `../nested/subdir`. Note that the XML and TXT
reports still use symlinks in paths, but that is another problem.

@latk latk referenced this pull request Jan 6, 2018

Merged

Fix HTML tests #185

latk added a commit to latk/gcovr that referenced this pull request Jan 9, 2018

fix HTML tests
The HTML tests are naturally rather fragile, since lots of CSS is copied
into every file. However, they are quite valuable as they exercise
important code paths. For example, this would have found issues gcovr#163
or gcovr#168. By enabling these tests, we can avoid such problems in the
future.

Summary of changes:

**`scripts/gcovr`:**
removed some trailing whitespace in the HTML template.

**`gcovr/tests/test_gcovr.py`:**
normalize HTML files so that they can be compared. In particular, we
remove the exact version string, and the report creation date.

**`gcovr/tests/*/reference/coverage.html`:**
update the HTML files to match the current structure. This is mostly
removing trailing whitespace, and tracking changes to the CSS. If there
was some discrepancy in the content, the TXT and XML references were
assumed to be up to date and fresh values taken from there.

**`gcovr/tests/linked/reference/coverage.html`:**
update as with the other tests. However, this exposed significant
changes to the path name handling. Commit 1cc987a changed
`commonprefix()` to `commonpath()` to figure out better path names. This
function is used only by the HTML test, which therefore reports physical
paths. The HTML reference has been updated to use physical paths. E.g.
since the test case is constructed on the fly from the “nested” test,
the source root dir is `../nested/subdir`. Note that the XML and TXT
reports still use symlinks in paths, but that is another problem.

JamesReynolds pushed a commit to JamesReynolds/gcovr that referenced this pull request Mar 8, 2018

fix HTML tests
The HTML tests are naturally rather fragile, since lots of CSS is copied
into every file. However, they are quite valuable as they exercise
important code paths. For example, this would have found issues gcovr#163
or gcovr#168. By enabling these tests, we can avoid such problems in the
future.

Summary of changes:

**`scripts/gcovr`:**
removed some trailing whitespace in the HTML template.

**`gcovr/tests/test_gcovr.py`:**
normalize HTML files so that they can be compared. In particular, we
remove the exact version string, and the report creation date.

**`gcovr/tests/*/reference/coverage.html`:**
update the HTML files to match the current structure. This is mostly
removing trailing whitespace, and tracking changes to the CSS. If there
was some discrepancy in the content, the TXT and XML references were
assumed to be up to date and fresh values taken from there.

**`gcovr/tests/linked/reference/coverage.html`:**
update as with the other tests. However, this exposed significant
changes to the path name handling. Commit 1cc987a changed
`commonprefix()` to `commonpath()` to figure out better path names. This
function is used only by the HTML test, which therefore reports physical
paths. The HTML reference has been updated to use physical paths. E.g.
since the test case is constructed on the fly from the “nested” test,
the source root dir is `../nested/subdir`. Note that the XML and TXT
reports still use symlinks in paths, but that is another problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment