New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves 164. #186

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Projects
None yet
3 participants
@libPhipp
Contributor

libPhipp commented Jan 7, 2018

Adding Cobertura's coverage-04.dtd attributes to the coverage-element and adjusting test references.

Resolves 164. Adding Cobertura's coverage-04.dtd attributes to the co…
…verage-element and adjusting test references.

@latk latk added the needs review label Jan 7, 2018

@@ -1,7 +1,7 @@
<?xml version="1.0" ?>
<?xml version="" ?>

This comment has been minimized.

@wolf99

wolf99 Jan 7, 2018

To double check, is this correct?
All other files with changes have the XML version added, this one has it removed...

This comment has been minimized.

@latk

latk Jan 7, 2018

Member

@wolf99 The files are sanitized by a few simple regexes, one of which removes the gcovr version. The files are edited on-disk, so the sanitized files ought to be committed.

Unfortunately this regex is a bit overzealous and also mangles the XML declaration. The result is technically not a well-formed XML document.

I've addressed those issues in #188, so that this PR can move forward independently.

@latk latk referenced this pull request Jan 7, 2018

Merged

Saner XML tests #188

@latk

latk approved these changes Jan 7, 2018

Fantastic work! Thank you very much for digging into this problem.

@latk latk merged commit e8fdcee into gcovr:master Jan 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@latk latk removed the needs review label Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment