New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #221

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
2 participants
@mayeut
Contributor

mayeut commented Feb 16, 2018

options.root can’t be None
Its default value is '.' since commit aaa733e

Remove unreachable code
options.root can’t be None
Its default value is ‘.’ since commit
aaa733e
@codecov

This comment has been minimized.

codecov bot commented Feb 16, 2018

Codecov Report

Merging #221 into master will increase coverage by 1.5%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #221     +/-   ##
========================================
+ Coverage    78.9%   80.4%   +1.5%     
========================================
  Files           2       2             
  Lines        1166    1143     -23     
  Branches      255     246      -9     
========================================
- Hits          920     919      -1     
+ Misses        171     153     -18     
+ Partials       75      71      -4
Impacted Files Coverage Δ
gcovr/__main__.py 78.31% <66.66%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42f7b4...fdd1af4. Read the comment docs.

@latk

latk approved these changes Feb 17, 2018

@latk latk merged commit b9c2677 into gcovr:master Feb 17, 2018

3 of 4 checks passed

codecov/patch 66.66% of diff hit (target 78.9%)
Details
codecov/project 80.4% (+1.5%) compared to d42f7b4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mayeut mayeut deleted the mayeut:unreachable branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment