Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move from optparse to argparse #237
Argparse is the better optparse. The only reason why we hadn't already switched was that argparse was only introduced in Python 2.7. Luckily there's a backport that can be installed from PyPI, so I added a version-dependent dependency.
The difficult part was enabling the necessary tests on Travis CI first. This surfaced a few compatibility problems that were accumulated in the recent refactorings. Especially
@@ Coverage Diff @@ ## master #237 +/- ## ========================================== - Coverage 87.37% 87.35% -0.03% ========================================== Files 12 12 Lines 1339 1336 -3 Branches 243 243 ========================================== - Hits 1170 1167 -3 Misses 115 115 Partials 54 54
The remaining test failure in the example XML just seems to be a whitespace issue:
possibly because of the --xml-pretty layout. There may be additional differences later in the file. The element in the error message is just the report directory.
It would be good to perhaps investigate this failure at some point, but the other tests pass without a problem so I don't think this failure is very important.