New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MINGW32_NT checks for test Makefiles (see #240). #241

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@landofcake
Contributor

landofcake commented Mar 7, 2018

Add checks for MINGW32_NT to filter-test2 and shared_lib test Makefiles and set BASE_OS to MSYS_NT.

@codecov

This comment has been minimized.

codecov bot commented Mar 7, 2018

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files          12       12           
  Lines        1339     1339           
  Branches      243      243           
=======================================
  Hits         1170     1170           
  Misses        115      115           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb74bd...0b6dfed. Read the comment docs.

@latk

latk approved these changes Mar 7, 2018

@latk

This comment has been minimized.

Member

latk commented Mar 7, 2018

Looks great! Thank you for working through all those errors to get the tests working on your Windows.

Under which name would you like to be credited in the AUTHORS file? If you don't specify any preference, I'll use your Github user name.

@landofcake

This comment has been minimized.

Contributor

landofcake commented Mar 7, 2018

I'm sorry @latk , I forgot to put my name in my github profile (Dave George), I've now added it so go ahead and use that. Thanks!

@latk latk merged commit 0b6dfed into gcovr:master Mar 7, 2018

4 checks passed

codecov/patch Coverage not affected when comparing dfb74bd...0b6dfed
Details
codecov/project 87.37% remains the same compared to dfb74bd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

latk added a commit that referenced this pull request Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment