Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of gcov error message "Could not open output file" #244

Merged
merged 1 commit into from Mar 11, 2018

Conversation

@MartinXMraz
Copy link
Contributor

@MartinXMraz MartinXMraz commented Mar 11, 2018

fixes #243.

AUTHORS.txt Outdated
@@ -23,6 +23,7 @@ The following developers contributed to gcovr (ordered alphabetically):
libPhipp,
Lukas Atkinson,
Luke Woydziak,
Martin Mraz,
Copy link
Member

@latk latk Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You used tabs instead of spaces here – could you update that?

Loading

gcovr/gcov.py Outdated
@@ -17,7 +17,7 @@
from .utils import aliases, search_file, Logger

output_re = re.compile("[Cc]reating [`'](.*)'$")
source_re = re.compile("[Cc]annot open (source|graph) file")
source_re = re.compile("[Cc][annot|ould not] open (source|graph|output) file")
Copy link
Member

@latk latk Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to use a regex group, not a character class for [annot|ould not](annot|ould not).

Loading

@codecov
Copy link

@codecov codecov bot commented Mar 11, 2018

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          12       12           
  Lines        1336     1336           
  Branches      243      243           
=======================================
  Hits         1167     1167           
  Misses        115      115           
  Partials       54       54
Impacted Files Coverage Δ
gcovr/gcov.py 81.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4cc31...0893565. Read the comment docs.

Loading

latk
latk approved these changes Mar 11, 2018
@latk latk merged commit 89f7a85 into gcovr:master Mar 11, 2018
4 checks passed
Loading
@latk
Copy link
Member

@latk latk commented Mar 11, 2018

Thank you very much for fixing this!

Loading

@MartinXMraz MartinXMraz deleted the gcov-errors branch Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants