New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the dev branch #246
Merged
Merged
Close the dev branch #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally some decoupling. There is evidently more code that needs to be refactored, this is for base code refactoring.
… carlos-jenkins-module
The script is now a simple call to gcovr.ddriver.main_
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 13 13
Lines 1477 1477
Branches 267 267
=======================================
Hits 1311 1311
Misses 108 108
Partials 58 58 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By now, all changes from the dev branch have been reimplemented on master. This PR merges the dev branch into master, without applying any of the dev changes. That way, the Git history is retained and dev can be safely deleted.
While dev and master took some different directions (e.g. the module structure), they are now functionally equivalent. All bug fixes and enhancements that were made on dev have also been done on master.
Where large parts of code were extracted, I didn't review that carefully to ensure that no fixes were sneaked in together with the refactoring. The dev branch has one change to the HTML code that master doesn't have, but I don't understand why it might be necessary:
I think it is safe to ignore that, as the dates in the HTML are known to work – and that field isn't actually used anywhere.