New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Link to github issues from changelog page #249

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
2 participants
@chrta
Contributor

chrta commented Apr 6, 2018

This is work in progress. It should not be merged yet, since it is based on #248 and contains its commit also.
Only the last commit is relevant for this.

@codecov

This comment has been minimized.

codecov bot commented Apr 6, 2018

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          13       13           
  Lines        1477     1477           
  Branches      267      267           
=======================================
  Hits         1311     1311           
  Misses        108      108           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a771f...886450f. Read the comment docs.

@latk

This comment has been minimized.

Member

latk commented Apr 6, 2018

What remains to be done so that this PR loses its “WIP” status?

I can rebase it to the current master branch for you (I fiddled a bit with the commits of your other PR, so this PR doesn't appear to apply cleanly – but that's just GitHub being confused).

@chrta chrta force-pushed the chrta:link-issues-in-cl branch from 03c8290 to 42cf51a Apr 6, 2018

@chrta chrta changed the title from WIP: doc: Link to github issues from changelog page to doc: Link to github issues from changelog page Apr 6, 2018

@chrta

This comment has been minimized.

Contributor

chrta commented Apr 6, 2018

WIP status was just because the merge was not done yet.

Only the last commit should be necessary here.

@latk latk force-pushed the chrta:link-issues-in-cl branch from 42cf51a to 886450f Apr 6, 2018

@latk

latk approved these changes Apr 6, 2018

@latk latk merged commit fa8e801 into gcovr:master Apr 6, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 51a771f...886450f
Details
codecov/project 88.76% remains the same compared to 51a771f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment