Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support --source-encoding option. #256
@@ Coverage Diff @@ ## master #256 +/- ## ========================================== + Coverage 88.76% 88.83% +0.06% ========================================== Files 13 13 Lines 1478 1487 +9 Branches 267 268 +1 ========================================== + Hits 1312 1321 +9 Misses 108 108 Partials 58 58
This is fantastic! Thank you very much for looking into this. I'll review properly in the next couple of days.
BTW the Travis test failure was just a small style problem. To check for those before you commit you can run flake8 locally, e.g.
If you'd like to work on other issues, please consider first making a comment on the corresponding issue or mentioning this in the chat room. I really appreciate your work, but some issues first need some discussion on the best design.
Ok. Test should pass now.
I forgot run it locally. It is greate if there is a .flake8 file under the project root and autopep8 as well. modern editor with plugin may auto check if it is there(like vim, vs code).
Do you mind change the file contents to unicode in python2?
I've reviewed this PR more thoroughly. Encoding issues are difficult! I'll try to work on test cases with various encodings, and will not merge until there are some tests that work on all platforms.