New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New options --html-medium-thereshold and --html-high-threshold (:issu… #264

Merged
merged 1 commit into from Jun 16, 2018

Conversation

Projects
None yet
2 participants
@Spacetown
Contributor

Spacetown commented Jun 15, 2018

…e:#261)
New request after splitting #261 and problems with the repo.

@codecov

This comment has been minimized.

codecov bot commented Jun 15, 2018

Codecov Report

Merging #264 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #264     +/-   ##
=========================================
+ Coverage   89.57%   89.77%   +0.2%     
=========================================
  Files          13       13             
  Lines        1525     1555     +30     
  Branches      270      271      +1     
=========================================
+ Hits         1366     1396     +30     
  Misses        105      105             
  Partials       54       54
Impacted Files Coverage Δ
gcovr/__main__.py 94.44% <100%> (+0.17%) ⬆️
gcovr/tests/test_args.py 100% <100%> (ø) ⬆️
gcovr/html_generator.py 96.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a11a1...3a4ed18. Read the comment docs.

details = options.html_details
if options.output is None:
details = False
data = {}
data['HEAD'] = options.html_title
data['HEAD'] = options.title

This comment has been minimized.

@latk

latk Jun 15, 2018

Member

I think the tests are failing because of this line, otherwise this looks great!

This comment has been minimized.

@Spacetown

Spacetown Jun 15, 2018

Contributor

Already pushed. How do I start the test again?

This comment has been minimized.

@latk

latk Jun 15, 2018

Member

The tests restart automatically when you push. The remaining build failures are not test failures (wohoo!), but just style guide violations, see the build log: https://travis-ci.org/gcovr/gcovr/jobs/392858479#L925. To run the style checker locally, install flake8 from PyPI.

This comment has been minimized.

@Spacetown

Spacetown Jun 15, 2018

Contributor

Ok. At work I'm using SmartGit under Windows and at home I'm working with different tools under MacOs the first time.

@latk

This comment has been minimized.

Member

latk commented Jun 15, 2018

Thank you, this looks very good! I'll take a closer look tomorrow and merge.

I'm sorry that you had problems with Git, it can sometimes be totally confusing!

@Spacetown

This comment has been minimized.

Contributor

Spacetown commented Jun 15, 2018

I'm coming from IBM Rational ClearCase, that is also confusing. I'm working the first time with GitHub.

@latk latk force-pushed the Spacetown:addThresholdOptions branch from 20a15d1 to 3a4ed18 Jun 16, 2018

@latk

latk approved these changes Jun 16, 2018

@latk latk merged commit 3a4ed18 into gcovr:master Jun 16, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@latk

This comment has been minimized.

Member

latk commented Jun 16, 2018

Thank you for your contribution, it's merged now! I squashed the commits and touched up minor typos, which is why I had to force-push to this branch.

@Spacetown Spacetown deleted the Spacetown:addThresholdOptions branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment