Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty or missing argument for `--exclude` and `--exclude-directores` options #267

Closed
wants to merge 2 commits into from

Conversation

@mkurdej
Copy link
Contributor

mkurdej commented Jul 3, 2018

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #267 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   90.39%   90.53%   +0.14%     
==========================================
  Files          13       13              
  Lines        1551     1575      +24     
  Branches      268      269       +1     
==========================================
+ Hits         1402     1426      +24     
  Misses         98       98              
  Partials       51       51
Impacted Files Coverage Δ
gcovr/__main__.py 94.57% <100%> (+0.13%) ⬆️
gcovr/tests/test_args.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2165f...c4815ba. Read the comment docs.

@latk

This comment has been minimized.

Copy link
Member

latk commented Jul 3, 2018

Thank you for the PR! I've merged the “check for empty” commit. If it's OK I'll skip the “check for missing argument” test cases because they effectively test the behaviour of argparse, not of gcovr itself.

If you enjoy writing tests, there still is a lot to be covered. E.g. a test for the --print-summary option would be very welcome :)

@latk latk closed this Jul 3, 2018
@mkurdej mkurdej deleted the mkurdej:fix-empty-exclude branch Jul 4, 2018
@mkurdej

This comment has been minimized.

Copy link
Contributor Author

mkurdej commented Jul 4, 2018

Haha! We'll see :). Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.