Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions and fixes for json_generator #351

merged 3 commits into from Feb 16, 2020


Copy link

In this PR I try to:

I need a review for the second feature, because I am not sure whether is correctly implemented or should be done totally different.

Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #351 into master will increase coverage by 0.16%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
+ Coverage   95.02%   95.18%   +0.16%     
  Files          17       17              
  Lines        1949     1952       +3     
  Branches      338      339       +1     
+ Hits         1852     1858       +6     
  Misses         47       47              
+ Partials       50       47       -3
Impacted Files Coverage Δ
gcovr/ 97.27% <ø> (ø) ⬆️
gcovr/ 97.36% <50%> (ø) ⬆️
gcovr/ 91.62% <83.33%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b8899...39b1e37. Read the comment docs.

Copy link

@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution! Only minor comments below.

I independently discovered and fixed the --json --output issue as part of bcb22d2 on the html-rewrite branch. However, that branch is not yet ready for merging into master so I will apply your PR first.

gcovr/ Outdated Show resolved Hide resolved
doc/source/guide.rst Show resolved Hide resolved
Copy link
Contributor Author

@latk Thank you for your review. I was not aware about your fix for missing --output. I only noticed html-rewrite branch name and I have assumed that there is no changes for json output. I should check it more deeply. Sorry for that :).

@latk latk merged commit 39b1e37 into gcovr:master Feb 16, 2020
@CezaryGapinski CezaryGapinski deleted the json_add_coverages branch July 30, 2020 19:28
@Spacetown Spacetown added this to the 4.3 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants