New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions and fixes for json_generator #351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 95.02% 95.18% +0.16%
==========================================
Files 17 17
Lines 1949 1952 +3
Branches 338 339 +1
==========================================
+ Hits 1852 1858 +6
Misses 47 47
+ Partials 50 47 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great contribution! Only minor comments below.
I independently discovered and fixed the --json --output issue as part of bcb22d2 on the html-rewrite branch. However, that branch is not yet ready for merging into master so I will apply your PR first.
Add feature suggested in issue gcovr#338
6e3585c
to
39b1e37
Compare
@latk Thank you for your review. I was not aware about your fix for missing |
In this PR I try to:
I need a review for the second feature, because I am not sure whether is correctly implemented or should be done totally different.