Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html and json templates #367

merged 4 commits into from May 5, 2020


Copy link

@opikalo opikalo commented Apr 26, 2020

@latk: If you want to do me a huge favour and have an hour to spare: please check out the html-rewrite branch and regenerate the HTML test reference files (and add JSON reference files). They were deleted for a large refactoring. Go into each test directory, run the Makefile, and relevant generated files into the reference directory (might have to create it). That's the next step that I've been procrastinating.

This should do it. I left the regeneration code in place: I can remove it too. I think I did this right. There is a small change in scraping regexp to accommodate new HTML rewrite.

All files could be regenerated wheb GENERATE_REFENCE = True.
Also, minor change to regexp to accomodate for html rewrite.
@opikalo opikalo changed the title Add html templates Add html and json templates Apr 26, 2020
Copy link

latk commented Apr 26, 2020

Thank you so much! Adding that regeneration code is elegant. The CI failures are to be expected since the underlying code is probably slightly broken, but those don't hinder merging this PR. I'll do it as soon as I'm back at my development machine.

We do not need individual coverage file reports since they tend to
confuse reference machinery. Also, trying to fix windows HTML
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #367 into html-rewrite will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           html-rewrite     #367      +/-   ##
+ Coverage         94.31%   94.56%   +0.25%     
  Files                17       17              
  Lines              2022     2025       +3     
  Branches            358      358              
+ Hits               1907     1915       +8     
+ Misses               59       54       -5     
  Partials             56       56              
Impacted Files Coverage Δ
gcovr/tests/ 91.93% <ø> (+4.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4d1e7...fdb6b60. Read the comment docs.

latk added a commit that referenced this pull request May 5, 2020
The HTML output was completely overhauled and now features more modern
HTML that should be easier to extend. Importantly, CSS no longer has to
be inline!

This represents roughly six months of "work". Thank you for @opikalo
(#367) for dragging it over the finish line :)
@latk latk merged commit fdb6b60 into gcovr:html-rewrite May 5, 2020
@latk latk added QA related to testing, build infrastructure, etc Type: Enhancement labels May 5, 2020
@Spacetown Spacetown added this to the 4.3 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
QA related to testing, build infrastructure, etc Type: Enhancement
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants