New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload coverage data from GitHub actions. #455
Upload coverage data from GitHub actions. #455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 95.08% 95.53% +0.45%
==========================================
Files 20 20
Lines 2420 2441 +21
Branches 418 418
==========================================
+ Hits 2301 2332 +31
+ Misses 54 48 -6
+ Partials 65 61 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Differences in coverage are because the report is know generated under ubuntu. |
Would it be possible to collect coverage in one Windows build as well? Codecov merges multiple uploaded reports, which is helpful because we have some Windows- and some Linux-specific tests. I'll delete Appveyor ass soon as you say so, or when this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think the Appveyor config can be deleted as well.
@latk It seems that with the GitHub actions the data is visible as comment but the test is missing. I'll try to call the commen |
@latk The requred appveyor test can be removed. |
ok done, Appveyor is deleted. Thank you very much for making this possible! |
And what about the missing needed test? Was there a special configuration on appveyor? |
5db5065
to
bb80b50
Compare
I think the codecov website is just unreliable in the diff view, but is actually processing the correct data. So I don't think anything has to be fixed regarding coverage collection (at least on our part). |
Strange, now the codecov is listed again. ??? |
@latk Can we now remove appveyor tests? GCC5 is checked in Docker and Windows is checked with GCC-8.