New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --object-directory to scan for gcov data files #72

Merged
merged 2 commits into from Aug 6, 2016

Conversation

Projects
None yet
4 participants
@kblaschke
Contributor

kblaschke commented Nov 11, 2014

Fixes an issue with gcovr being run on projects with out-of-source
builds, e.g. CMake-based builds. If --object-directory is given, this
path will be scanned in addition to --root to find gcda/gcno files.

Possible fix for issue #64

Use --object-directory to scan for gcov data files
Fixes an issue with gcovr being run on projects with out-of-source
builds, e.g. CMake-based builds. If --object-directory is given, this
path will be scanned in addition to --root to find gcda/gcno files.
@DaMouse404

This comment has been minimized.

DaMouse404 commented Mar 6, 2015

Any feedback on why this isn't in yet? I've also come across problems and have patched my version to do this.

@theold190

This comment has been minimized.

theold190 commented May 27, 2015

What if --root is not specified, then the --object-directory is still ignored for searching for data files.

Shouldn't it be like this:
If --object-directory specified - add it to searching paths
if -- root is specified - add it to searching paths
if no path is specified - search in the current directory

@kblaschke

This comment has been minimized.

Contributor

kblaschke commented Oct 16, 2015

@theold190 valid point, I amended my changes to implement your proposal. Sorry for the delay.

@DaMouse404 The last commit to the upstream repository has been made over a year ago, so it seems that the maintainer is no longer paying attention to the project.

@nickbroon nickbroon referenced this pull request May 5, 2016

Merged

fixed --root option #108

@whart222 whart222 merged commit 105890c into gcovr:master Aug 6, 2016

@whart222

This comment has been minimized.

Member

whart222 commented Aug 6, 2016

This commit merged these changes and resolved associated conflicts. However, I'm going to add a ticket, since we don't have tests to verify this new behavior.

@theold190

This comment has been minimized.

theold190 commented Sep 2, 2016

Nice!

nickbroon added a commit to nickbroon/gcovr that referenced this pull request Nov 30, 2016

Out of Source build that reflects proper use case
The following change to the oos testcase, such that I believe it more
closely reflects how tools like autoconf/automake/cmake perform out of
source builds (what they call vpath builds)

It currently fails, showing the gcovr is issues with oos paths.
See github issues gcovr#61 gcovr#64 gcovr#72 gcovr#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment