Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space between fa-folder icon and category name missing when site is built with --minify flag. #1219

Closed
abahgat opened this issue Jul 22, 2019 · 4 comments

Comments

@abahgat
Copy link
Contributor

commented Jul 22, 2019

I guess it never surfaced on the demo site because none of the posts there seem to use Categories.

I don't know whether that's the only issue, but it's the only difference I have been able to notice so far.

@abahgat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

This might be one of the cases where a nonbreaking space might be warranted by the way. Are you aware of any better alternatives?

@gcushen gcushen added the bug label Jul 23, 2019

@gcushen gcushen closed this in 310357e Jul 23, 2019

@abahgat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Thanks for the quick turnaround!

However, I do think a &npbs; is worth consideration here since it's pretty common for lines to wrap around tags and arrangements like the ones in the screenshot below are fairly common.

Ideally, I imagine we'd want the icon and the categories to be on the same rows, right?

academic-demo netlify com_

@abahgat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Any thoughts on this?
When visiting my site on mobile, any posts displayed using a card layout will wrap between the icon and the category name, so I'd look to fix this on a local fork if you think it's not something we want to do by default.

www abahgat com_(Pixel 2 XL)

@abahgat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

Hey @gcushen sorry for being a nag, but I was wondering whether you had any thoughts on the question in my comment above.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.