New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Font Awesome 5 #541

Closed
chris-prener opened this Issue May 18, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@chris-prener
Copy link

chris-prener commented May 18, 2018

I am wondering whether it would be possible to enable font awesome 5? It looks like cdnjs does not include Font Awesome 5, but they have their own CDN that could be used - https://fontawesome.com/get-started

I hope you consider it @gcushen - I love the theme and the continued support you give it and your users! Thanks!

@gcushen

This comment has been minimized.

Copy link
Owner

gcushen commented May 18, 2018

Thanks for the suggestion. I don't see why not, once FA team enable CDNJS to be updated to v5. There is some work involved in upgrading Academic from FA v4 to v5 though since v5 is rewritten from scratch.

Steps to upgrade:

Dependent on:

@gcushen gcushen changed the title Font Awesome 5? Upgrade to Font Awesome 5 May 18, 2018

This was referenced Aug 28, 2018

@Nosferican

This comment has been minimized.

Copy link

Nosferican commented Sep 8, 2018

Should this be closed by #659?

@gcushen

This comment has been minimized.

Copy link
Owner

gcushen commented Sep 8, 2018

@Nosferican #659 mostly resolves this. Ideally, we would use CDNJS as the CDN, but the CDNJS version is broken and unknown when it'll be fixed (see links in the description), so I'll go ahead and close this for now.

We can revisit this in the future to check if CDNJS/FA5 teams have fixed their FA5 packaging.

@gcushen gcushen closed this Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment