Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify featurette class column to have two skills per row in mobile #823

Closed
wants to merge 1 commit into from

Conversation

@haidaraM
Copy link

haidaraM commented Nov 26, 2018

Purpose

This little change allow to have two skills per row on mobile. It was only one per row and it took unnecessary width.

Screenshots

Before:
before

After the changes:
after

The layout remains unchanged on bigger screen.

@gcushen

This comment has been minimized.

Copy link
Owner

gcushen commented Dec 31, 2018

The optimum depends on what sized devices your visitors have - you are assuming visitors will have large mobile devices like iPhone8.

It's safer to leave the responsive value as it is so that the widget displays well on all devices, including small devices such as iPhone SE etc.

@gcushen gcushen closed this Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.