New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finally got appengine-magic working with lein 2 #74

Merged
merged 5 commits into from Jan 29, 2014

Conversation

Projects
None yet
3 participants
@avishai-ish-shalom
Contributor

avishai-ish-shalom commented Aug 24, 2013

removed dev dependencies from WEB-INF/lib; appengine-prepare is working.

@gcv

This comment has been minimized.

Show comment
Hide comment
@gcv

gcv Aug 24, 2013

Owner

This looks good! I'm away from my machine for the next week, but I'll merge this change in as soon as I return.

Owner

gcv commented Aug 24, 2013

This looks good! I'm away from my machine for the next week, but I'll merge this change in as soon as I return.

@gcv

This comment has been minimized.

Show comment
Hide comment
@gcv

gcv Sep 3, 2013

Owner

I like your patch, but while testing it, I discovered that it has an implicit dependency on JDK 7. me.raynes.fs uses java.nio.file.Files, which does not exist on JDK 6. I myself write Clojure using the basic JDK 6 included with OS X, and am uncomfortable making my libraries incompatible with such a widely installed JDK. Any chance you could replace the dependency with something like Apache Commons IO, which I think provides similar functionality to me.raynes.fs and is already an appengine-magic dependency?

Owner

gcv commented Sep 3, 2013

I like your patch, but while testing it, I discovered that it has an implicit dependency on JDK 7. me.raynes.fs uses java.nio.file.Files, which does not exist on JDK 6. I myself write Clojure using the basic JDK 6 included with OS X, and am uncomfortable making my libraries incompatible with such a widely installed JDK. Any chance you could replace the dependency with something like Apache Commons IO, which I think provides similar functionality to me.raynes.fs and is already an appengine-magic dependency?

@avishai-ish-shalom

This comment has been minimized.

Show comment
Hide comment
@avishai-ish-shalom

avishai-ish-shalom Sep 3, 2013

Contributor

Sure, i'll rewrite.

Contributor

avishai-ish-shalom commented Sep 3, 2013

Sure, i'll rewrite.

@avishai-ish-shalom

This comment has been minimized.

Show comment
Hide comment
@avishai-ish-shalom

avishai-ish-shalom Sep 7, 2013

Contributor

It seems that me.raynes.fs does not require jdk 7. i looks like the code will test for jdk 7 features at compile time and should work just fine with jdk 6 - look here. If you are still unhappy with raynes.fs, i'll rewrite with apache commons-io as requested.

Contributor

avishai-ish-shalom commented Sep 7, 2013

It seems that me.raynes.fs does not require jdk 7. i looks like the code will test for jdk 7 features at compile time and should work just fine with jdk 6 - look here. If you are still unhappy with raynes.fs, i'll rewrite with apache commons-io as requested.

@gcv

This comment has been minimized.

Show comment
Hide comment
@gcv

gcv Sep 20, 2013

Owner

Hey, sorry about the delayed response... I see what you mean, but when I use your patch and then run lein appengine-clean inside a project, I get this:

java.lang.ClassNotFoundException: java.nio.file.Files
    at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
    at clojure.lang.DynamicClassLoader.findClass(DynamicClassLoader.java:61)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:171)
    at me.raynes.fs$eval19$loading__4910__auto____20.invoke(fs.clj:1)
    at me.raynes.fs$eval19.invoke(fs.clj:1)

java.nio.file.Files is a JDK 7 feature.

Owner

gcv commented Sep 20, 2013

Hey, sorry about the delayed response... I see what you mean, but when I use your patch and then run lein appengine-clean inside a project, I get this:

java.lang.ClassNotFoundException: java.nio.file.Files
    at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
    at clojure.lang.DynamicClassLoader.findClass(DynamicClassLoader.java:61)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:171)
    at me.raynes.fs$eval19$loading__4910__auto____20.invoke(fs.clj:1)
    at me.raynes.fs$eval19.invoke(fs.clj:1)

java.nio.file.Files is a JDK 7 feature.

@avishai-ish-shalom

This comment has been minimized.

Show comment
Hide comment
@avishai-ish-shalom

avishai-ish-shalom Sep 21, 2013

Contributor

you are correct. Apparently (try (import )) is not available in 1.4.4, upgraded to 1.4.5 which does contains this.

Contributor

avishai-ish-shalom commented Sep 21, 2013

you are correct. Apparently (try (import )) is not available in 1.4.4, upgraded to 1.4.5 which does contains this.

@roti

This comment has been minimized.

Show comment
Hide comment
@roti

roti Jan 27, 2014

So, any chances these changes will be accepted in the near future?

roti commented Jan 27, 2014

So, any chances these changes will be accepted in the near future?

@gcv gcv merged commit 63208ac into gcv:master Jan 29, 2014

@gcv

This comment has been minimized.

Show comment
Hide comment
@gcv

gcv Jan 29, 2014

Owner

Thanks, and apologies again for the delay. Since I upgraded to Mavericks, I don't have a Java 6 SDK anymore, so I couldn't really test if that last change worked, but I guess that matters much less now.

Owner

gcv commented Jan 29, 2014

Thanks, and apologies again for the delay. Since I upgraded to Mavericks, I don't have a Java 6 SDK anymore, so I couldn't really test if that last change worked, but I guess that matters much less now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment