Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support Go Modules #249
Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.
Because this library is still below version 2 and is already using semver compatible tags, the
It should also be noted that I picked 1.5 as the version of the Go language being used because it was the earliest version that the CI config was testing against; this won't break compatibility with 1.5, but it won't be able to use the mod file and I'm not sure if the new tooling actually supports warning about using newer language features and APIs that far back. At worse though this is no different than today and nothing will be broken.
Thank you for your consideration.
@@ Coverage Diff @@ ## master #249 +/- ## ========================================= + Coverage 19.69% 19.7% +0.01% ========================================= Files 17 17 Lines 1442 1441 -1 ========================================= Hits 284 284 + Misses 1141 1140 -1 Partials 17 17
Waiting for CI/CD. I may want to rethink our use of goconvey in the future. .. it brings in a lot of additional dependencies, which most of the times we don't need (only for test).
Probably also I will want to bump the go version -- go versions below 1.9 won't see that file anyway, and I need to stop trying to support go versions that the go team have deprecated.
Sounds good; I pushed a change to test/support Go 1.9+ instead.
It appears to only be my machine, but on Go 1.12 beta1 it actually causes a panic when running tests for me. I have no idea why; something deep in the bowels of goconvey. Go 1.11 works fine and tests pass. I'm not sure why that would be, but it does seem like a lot of additional complexity just to run tests.
EDIT2: Oh goodness, I just noticed it's using gls (and that appears to be where the problem is) no wonder it's failing.
Dec 20, 2018
4 of 5 checks passed
Yes, I will do so momentarily. I’m probably going to be making other changes to this code soon… I want to fix Windows terminal stuff for 256 color and there are some other PRs I really need to work on. - Garrett Sent from Mail for Windows 10 From: Sam Whited Sent: Thursday, December 20, 2018 3:18 PM To: gdamore/tcell Cc: gdamore; State change Subject: Re: [gdamore/tcell] Support Go Modules (#249) Thanks for the merge! Any chance this can be tagged with a version I can pin too now? Thanks again. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.