New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color is added to colorize the app #67

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
2 participants
@tasomaniac
Member

tasomaniac commented Mar 14, 2015

Look at the top 馃槃
screenshot_2015-03-14-02-33-35

Actually I am open to the ideas of this color. Since the navigation bar is grey, it look good but can be better.

@tasomaniac

This comment has been minimized.

Show comment
Hide comment
@tasomaniac

tasomaniac Mar 14, 2015

Member

And as can be seen on the screenshot, I've also added "Add to homescreen" suggestion popup.
http://updates.html5rocks.com/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android

It is shown if the user opens the webpage in 2 separate days in 2 weeks.
I need #65 to be merged to send another PR for this.

Member

tasomaniac commented Mar 14, 2015

And as can be seen on the screenshot, I've also added "Add to homescreen" suggestion popup.
http://updates.html5rocks.com/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android

It is shown if the user opens the webpage in 2 separate days in 2 weeks.
I need #65 to be merged to send another PR for this.

ozasadnyy added a commit that referenced this pull request Mar 14, 2015

@ozasadnyy ozasadnyy merged commit 378dcd3 into gdg-x:master Mar 14, 2015

@ozasadnyy

This comment has been minimized.

Show comment
Hide comment
@ozasadnyy

ozasadnyy Mar 14, 2015

Member

Oh, yes. I forgot to add it to Zeppelin. Thanks for a PR.
About #65 please look at the my comment.

Member

ozasadnyy commented Mar 14, 2015

Oh, yes. I forgot to add it to Zeppelin. Thanks for a PR.
About #65 please look at the my comment.

@tasomaniac

This comment has been minimized.

Show comment
Hide comment
@tasomaniac

tasomaniac Mar 14, 2015

Member

I really love the similiarity between our Buy Tickets buttons and Chrome's Add to Homescreen button. It looks like it is the part of the website and looks great.

Member

tasomaniac commented Mar 14, 2015

I really love the similiarity between our Buy Tickets buttons and Chrome's Add to Homescreen button. It looks like it is the part of the website and looks great.

@ozasadnyy

This comment has been minimized.

Show comment
Hide comment
@ozasadnyy

ozasadnyy Mar 14, 2015

Member

Yeap, but I guess we should move theme-color to variables and set it to #03a9f4. Then everywhere we will ise the same color.

Member

ozasadnyy commented Mar 14, 2015

Yeap, but I guess we should move theme-color to variables and set it to #03a9f4. Then everywhere we will ise the same color.

@tasomaniac

This comment has been minimized.

Show comment
Hide comment
@tasomaniac

tasomaniac Mar 14, 2015

Member

Definitely. I was thinking about that. Women Techmakers colors are slightly different for example. Since the website looks ok now, I didn't start with it. It should be variable and change most of the places.
http://wtmistanbul.com/

Member

tasomaniac commented Mar 14, 2015

Definitely. I was thinking about that. Women Techmakers colors are slightly different for example. Since the website looks ok now, I didn't start with it. It should be variable and change most of the places.
http://wtmistanbul.com/

@tasomaniac tasomaniac deleted the tasomaniac:feature/lollipop-toolbar-color branch Mar 14, 2015

@tasomaniac tasomaniac referenced this pull request Mar 14, 2015

Merged

Install banner #69

@ozasadnyy

This comment has been minimized.

Show comment
Hide comment
@ozasadnyy

ozasadnyy Mar 14, 2015

Member

You can do this in simple way. Jusy edit _base.scss

// Colors
$main-color: #03a9f4;
$link-color: $main-color;
$link-lighten-amount: 20%;
$base-background-color: #fff;
$base-section-background-color: $link-color;
$primary-color: #4285f4;
$primary-color-hover: #3266d5;
$icon-fill-color: #8b8b8b;
Member

ozasadnyy commented Mar 14, 2015

You can do this in simple way. Jusy edit _base.scss

// Colors
$main-color: #03a9f4;
$link-color: $main-color;
$link-lighten-amount: 20%;
$base-background-color: #fff;
$base-section-background-color: $link-color;
$primary-color: #4285f4;
$primary-color-hover: #3266d5;
$icon-fill-color: #8b8b8b;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment