New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple highlighted posts breaks share button #31

Closed
hallelulius opened this Issue Jan 7, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@hallelulius

When using multiple highlighted post there is an issue with the share button. The most recent one works but opens all share buttons on highlighted posts. An easy fix would be to include the post name in the id of the button and for in the ul like:

<button class="mdl-button mdl-js-button mdl-js-ripple-effect mdl-button--icon" id="btn-high-{{ post.title }}">
<ul class="mdl-menu mdl-js-menu mdl-menu--bottom-right" for="btn-high-{{ post.title }}">

@oscarmcm oscarmcm added the bug label Jan 7, 2016

@oscarmcm oscarmcm added this to the jekyll-mdl 2.0 version milestone Jan 7, 2016

@oscarmcm oscarmcm self-assigned this Jan 7, 2016

oscarmcm added a commit that referenced this issue Jan 7, 2016

JKM-31 Fix share button in highlight post #31
Caused by duplicated identifiers in button and item share list. Add the post id to differentiate the post

oscarmcm added a commit that referenced this issue Jan 7, 2016

Merge pull request #32 from gdg-managua/JKM-31
JKM-31 Fix share button in highlight post #31
@oscarmcm

This comment has been minimized.

Show comment
Hide comment
@oscarmcm

oscarmcm Jan 7, 2016

Member

Fixed #32

Thanks @hallelulius 👍

Member

oscarmcm commented Jan 7, 2016

Fixed #32

Thanks @hallelulius 👍

@oscarmcm oscarmcm closed this Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment