New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: Fix images displaying wider than card #26

Merged
merged 2 commits into from Nov 6, 2015

Conversation

Projects
None yet
2 participants
@thunsaker
Contributor

thunsaker commented Nov 2, 2015

Fixes #25

Added example to "Google Developers Group" post to show issue.

Show outdated Hide outdated _sass/_post.scss
@@ -30,3 +30,7 @@
}
}
p img {

This comment has been minimized.

@oscarmcm

oscarmcm Nov 2, 2015

Member

Awesome, @thunsaker can you move this to .post-content class?

@oscarmcm

oscarmcm Nov 2, 2015

Member

Awesome, @thunsaker can you move this to .post-content class?

This comment has been minimized.

@thunsaker

thunsaker Nov 2, 2015

Contributor

Sure thing.

Does it still need to be wrapped by the <p> tag? Might be redundant at this point, after moving it into the appropriate selector.

@thunsaker

thunsaker Nov 2, 2015

Contributor

Sure thing.

Does it still need to be wrapped by the <p> tag? Might be redundant at this point, after moving it into the appropriate selector.

This comment has been minimized.

@oscarmcm

oscarmcm Nov 2, 2015

Member

Nop, just

.post-content { img { width: 100% } }

because in this mode no matter if they are inside a <p> or a <li> or whatever, all the image should adjust to the content width 😄 .

@oscarmcm

oscarmcm Nov 2, 2015

Member

Nop, just

.post-content { img { width: 100% } }

because in this mode no matter if they are inside a <p> or a <li> or whatever, all the image should adjust to the content width 😄 .

@oscarmcm oscarmcm added the enhancement label Nov 2, 2015

@oscarmcm oscarmcm added this to the jekyll-mdl 2.0 version milestone Nov 2, 2015

@oscarmcm oscarmcm self-assigned this Nov 2, 2015

oscarmcm added a commit that referenced this pull request Nov 6, 2015

Merge pull request #26 from thunsaker/feature/img-width
🐛 Fix images displaying wider than card

@oscarmcm oscarmcm merged commit db4487a into gdgmanagua:master Nov 6, 2015

@oscarmcm

This comment has been minimized.

Show comment
Hide comment
@oscarmcm

oscarmcm Nov 6, 2015

Member

@thunsaker awesome 👍 thanks for your contribution 😄

Member

oscarmcm commented Nov 6, 2015

@thunsaker awesome 👍 thanks for your contribution 😄

@thunsaker thunsaker deleted the thunsaker:feature/img-width branch Nov 6, 2015

oscarmcm added a commit that referenced this pull request Nov 16, 2015

Merge pull request #26 from thunsaker/feature/img-width
🐛 Fix images displaying wider than card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment