#151 & #161: Updated instructions for local python http server #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Created Resources directory as a repository for commonly used instructions (like how to run a local server) *Moved testinglocally.html into Resources directory and edited for further clarification and to add Chromebook instructions. *Updated links in all exercises which previously referenced testinglocally.html or gave direct instructions for setting up a local server.
| @@ -16,7 +16,8 @@ | |||
|
|
|||
| <h2>Setup</h2> | |||
| <ol> | |||
| <li>If you are not yet running your code from a local server, do that now by running <code>python -m SimpleHTTPServer</code> from your directory. We need to do this because of security restrictions on file:// protocol with XMLHttpRequests.</li> | |||
| <li>If you are not yet running your code from a local server, do that now by following | |||
| <a href="../resources/testinglocally.html" target="_blank">these instructions</a>. We need to do this because of security restrictions on file:// protocol with XMLHttpRequests.</li> | |||
There was a problem hiding this comment.
I think these need at least one more ../ in the URL. @verythorough can you test and update?
|
Awesome work! I had one comment about the URL for some nested files, but otherwise, looks great! |
Fixes bad links in backbone rolodex exercises and makes copying and pasting to new exercises easier.
|
Yes! Too quickly copy-pasting between files. I ended up changing all of the links to be root-relative rather than file-relative, to avoid such copy-paste errors in future instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed in #151:
*Created resources directory for storing commonly used instructions (like how to run a local server)
*Moved testinglocally.html into resources directory and edited for further clarification and to add Chromebook instructions
*Updated links in all exercises which previously referenced testinglocally.html or gave direct instructions for setting up a local server