Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement scheduled publishing #129

Merged
merged 12 commits into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
Contributor

vinayvinay commented Mar 5, 2014

Editors need to publish ready items at a specific time and date in the future when many items need to be published during out-of-office hours.

related publisher feature-branch.

@alext alext and 1 other commented on an outdated diff Mar 5, 2014

app/models/edition.rb
@@ -242,6 +240,7 @@ def broadcast_action(callback_action)
end
def was_published
+ update_attribute :publish_at, nil
@alext

alext Mar 5, 2014

Contributor

Would this be better handled by a before_transition :on => :publish hook. That would avoid doing 2 db writes, and possible inconsistency should one fail.

@vinayvinay

vinayvinay Mar 5, 2014

Contributor

fair point @alext, corrected!

Contributor

vinayvinay commented Mar 5, 2014

@alext - removed the extra parameter you pointed out, thanks !

alext added a commit that referenced this pull request Mar 5, 2014

@alext alext merged commit 8a97d44 into master Mar 5, 2014

1 check passed

default "Build #9 succeeded on Jenkins"
Details

@alext alext deleted the implement-scheduled-publishing branch Mar 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment