State transition bug fix #130

Merged
merged 2 commits into from Mar 5, 2014

Conversation

2 participants
Contributor

bishboria commented Mar 5, 2014

Any user should be able to request amendments on possible content, except if they just requested a review of the same content.

State transition bug fix:
Any user should be able to request amendments on possible content, except if they just requested a review of the same content.
app/models/workflow_actor.rb
@@ -132,13 +132,16 @@ def can_approve_review?(edition)
# To accommodate latest_status_action being nil, we'll always return true in
# those cases
# This is intended as a v.temporary fix until we can remedy the root cause
@alext

alext Mar 5, 2014

Contributor

Does this comment need to move to the new method?

Contributor

bishboria commented Mar 5, 2014

@alext Moved the comment.

alext added a commit that referenced this pull request Mar 5, 2014

@alext alext merged commit 29541ce into master Mar 5, 2014

1 check passed

default "Build #11 succeeded on Jenkins"
Details

@alext alext deleted the bug-fix-request-amendments-transition branch Mar 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment