New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VM IP pools #68

Merged
merged 4 commits into from May 30, 2014

Conversation

Projects
None yet
3 participants
@geriBatai
Contributor

geriBatai commented May 29, 2014

@@ -241,6 +241,22 @@ module Core
@vm.configure_network_interfaces(network_config)
end
it "should configure nic from pool" do

This comment has been minimized.

@annashipman

annashipman May 29, 2014

Contributor

👍 for adding tests! Thank you!

@annashipman

annashipman May 29, 2014

Contributor

👍 for adding tests! Thank you!

@mattbostock mattbostock referenced this pull request May 29, 2014

Closed

Support for VM IP pools #35

@geriBatai

This comment has been minimized.

Show comment
Hide comment
@geriBatai

geriBatai May 30, 2014

Contributor

Rearranged allocation_mode selection so it would be forced to be manual if ip address is specified, and use DHCP as a default.

Contributor

geriBatai commented May 30, 2014

Rearranged allocation_mode selection so it would be forced to be manual if ip address is specified, and use DHCP as a default.

ip_address = network[:ip_address]
connection[:IpAddress] = ip_address unless ip_address.nil?
connection[:IpAddressAllocationMode] = ip_address ? 'MANUAL' : 'DHCP'
ip_address = network[:ip_address]

This comment has been minimized.

@mattbostock

mattbostock May 30, 2014

Contributor

Since ip_address is not changed, I don't think it's necessary to declare this separately - could we rely on network[:ip_address] directly instead?

@mattbostock

mattbostock May 30, 2014

Contributor

Since ip_address is not changed, I don't think it's necessary to declare this separately - could we rely on network[:ip_address] directly instead?

@geriBatai

This comment has been minimized.

Show comment
Hide comment
@geriBatai

geriBatai May 30, 2014

Contributor

This code is the same as before. I think ip_address and allocation_mode as vars just make this part more readable.

Contributor

geriBatai commented May 30, 2014

This code is the same as before. I think ip_address and allocation_mode as vars just make this part more readable.

@mattbostock

This comment has been minimized.

Show comment
Hide comment
@mattbostock

mattbostock May 30, 2014

Contributor

That's fair, let's leave it as-is. Thanks for your work on this Simas, much appreciated!

Contributor

mattbostock commented May 30, 2014

That's fair, let's leave it as-is. Thanks for your work on this Simas, much appreciated!

mattbostock added a commit that referenced this pull request May 30, 2014

@mattbostock mattbostock merged commit a89b39d into gds-operations:master May 30, 2014

@mattbostock

This comment has been minimized.

Show comment
Hide comment
@mattbostock

mattbostock May 30, 2014

Contributor

This will be released in version 0.5.0: #71 🎉

Contributor

mattbostock commented May 30, 2014

This will be released in version 0.5.0: #71 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment