New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'persistence' session support to the xml schema for the Load Balancer service #36

Closed
Azulinho opened this Issue Mar 26, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@Azulinho
Copy link

Azulinho commented Mar 26, 2014

From the Readme.md:
"
For the 'https' service_profile, we can use SSL Session ID based persistence:

https:
port: 8443
persistence:
method: SSL_SESSION_ID
"

However 'persistence' is not defined in the provided schema file. So it can't be used while deploying LoadBalancer rules.

'persistence' only seems to be defined in the 'mock' tests.

annashipman added a commit that referenced this issue Mar 28, 2014

We do not actually support persistence
See #36. I am removing it from the README for now and have raised a bug in Pivotal https://www.pivotaltracker.com/story/show/68445956 to add support later.
@annashipman

This comment has been minimized.

Copy link
Contributor

annashipman commented Mar 28, 2014

Hi @Azulinho, thanks very much for raising this! It's not something we use ourselves so we hadn't noticed.

I've raised a bug in our backlog to address this (though as ever, Pull Requests very welcome if you get to it first) and a PR to remove it from the README until it is fixed: #38

Thanks again!

@mattbostock

This comment has been minimized.

Copy link
Contributor

mattbostock commented Mar 28, 2014

For reference when implementing this, the schema being referred to is in lib/vcloud/schema/load_balancer_service.rb.

mikepea added a commit that referenced this issue May 14, 2014

Add missing schema for virtual_server persistence
There was no schema defined for virtual_server persistence method,
which resulted in #36
being raised.

This adds the missing schema, and tests to confirm it is working.

It reflects that COOKIE method is available via http, SSL_SESSION_ID via https, and
nothing via tcp.
@mikepea

This comment has been minimized.

Copy link
Contributor

mikepea commented May 15, 2014

Hi @Azulinho, the persistence method you need should now be available on the master branch. Could you check whether it fixes your problem?

@mikepea mikepea reopened this May 15, 2014

@mattbostock

This comment has been minimized.

Copy link
Contributor

mattbostock commented May 21, 2014

Closing now that this functionality has been implemented. @Azulinho, please let us know should you encounter any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment