From c7a9c17539ca4f49a13d5ef1ec19a6f37ba6dcef Mon Sep 17 00:00:00 2001
From: Joaquin Matres <4514346+joamatab@users.noreply.github.com>
Date: Mon, 4 Dec 2023 13:33:54 -0800
Subject: [PATCH 1/3] fix docs

---
 docs/notebooks/workflow_2_ring.py | 16 +++++++++++-----
 pyproject.toml                    |  2 +-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/docs/notebooks/workflow_2_ring.py b/docs/notebooks/workflow_2_ring.py
index a892a4ea..07cd29b7 100644
--- a/docs/notebooks/workflow_2_ring.py
+++ b/docs/notebooks/workflow_2_ring.py
@@ -178,13 +178,16 @@ def ring(
 
 gaps = [210 * nm, 220 * nm, 230 * nm]
 rings_heater = [
-    gf.components.ring_single_heater(gap=0.2, radius=10, length_x=4) for gap in gaps
+    gf.components.ring_single_heater(
+        gap=0.2, radius=10, length_x=4, name=f"ring_heater_{int(gap*1e3)}"
+    )
+    for gap in gaps
 ]
 rings_heater_with_grating_couplers = [
     gf.routing.add_fiber_array(ring) for ring in rings_heater
 ]
 rings_with_pads = [
-    gf.routing.add_electrical_pads_top(ring)
+    gf.routing.add_electrical_pads_top(ring, name=f"{ring.name}_pads")
     for ring in rings_heater_with_grating_couplers
 ]
 
@@ -200,7 +203,7 @@ def reticle(size=(1000, 1000)):
     )
     m.xmin = r.xmax + 10
     m.ymin = r.ymin
-    c << gf.components.seal_ring(c.bbox)
+    _ = c << gf.components.seal_ring(c.bbox)
     return c
 
 
@@ -214,8 +217,9 @@ def reticle(size=(1000, 1000)):
 
 gaps = [210 * nm, 220 * nm, 230 * nm]
 rings = gf.grid([ring_te(gap=gap, decorator=gf.labels.add_label_json) for gap in gaps])
+
 rings_heater = [
-    gf.components.ring_single_heater(gap=0.2, radius=10, length_x=4) for gap in gaps
+    gf.components.ring_single_heater(gap=gap, radius=10, length_x=4) for gap in gaps
 ]
 rings_heater_with_grating_couplers = [
     gf.routing.add_fiber_array(ring) for ring in rings_heater
@@ -235,7 +239,7 @@ def reticle(size=(1000, 1000)):
     m = c << gf.pack(rings_with_pads)[0]
     m.xmin = r.xmax + 10
     m.ymin = r.ymin
-    c << gf.components.seal_ring(c.bbox)
+    _ = c << gf.components.seal_ring(c.bbox)
     return c
 
 
@@ -257,3 +261,5 @@ def reticle(size=(1000, 1000)):
 gf.labels.write_labels.write_labels_klayout(
     gdspath=gdspath, layer_label="TEXT", prefix=""
 )
+
+# %%
diff --git a/pyproject.toml b/pyproject.toml
index e65f666a..bc43d216 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -14,7 +14,7 @@ classifiers = [
   "Operating System :: OS Independent"
 ]
 dependencies = [
-  "gdsfactory[cad]>=7.8.1,<7.9",
+  "gdsfactory[cad]>=7.8.1,<7.10",
   "pint"
 ]
 description = "gdsfactory plugins"

From 5b0fdabb707be371b083fc0867c128bc169dc761 Mon Sep 17 00:00:00 2001
From: Joaquin Matres <4514346+joamatab@users.noreply.github.com>
Date: Mon, 4 Dec 2023 13:34:44 -0800
Subject: [PATCH 2/3] remove upper bound

---
 pyproject.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pyproject.toml b/pyproject.toml
index bc43d216..7ca9d16a 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -14,7 +14,7 @@ classifiers = [
   "Operating System :: OS Independent"
 ]
 dependencies = [
-  "gdsfactory[cad]>=7.8.1,<7.10",
+  "gdsfactory[cad]>=7.8.1",
   "pint"
 ]
 description = "gdsfactory plugins"

From 322366f80950c35ec3364a74d875bab04f62c5ab Mon Sep 17 00:00:00 2001
From: Joaquin Matres <4514346+joamatab@users.noreply.github.com>
Date: Mon, 4 Dec 2023 13:40:05 -0800
Subject: [PATCH 3/3] remove empty cell

---
 docs/notebooks/workflow_2_ring.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/docs/notebooks/workflow_2_ring.py b/docs/notebooks/workflow_2_ring.py
index 07cd29b7..d9a31242 100644
--- a/docs/notebooks/workflow_2_ring.py
+++ b/docs/notebooks/workflow_2_ring.py
@@ -261,5 +261,3 @@ def reticle(size=(1000, 1000)):
 gf.labels.write_labels.write_labels_klayout(
     gdspath=gdspath, layer_label="TEXT", prefix=""
 )
-
-# %%