Geoffrey De Smet ge0ffrey

Organizations

@droolsjbpm @mvel @pressgang
@ge0ffrey
  • @ge0ffrey 34d7f4f
    PLANNER-421 Avoid undoMove.toString()
@ge0ffrey
  • @ge0ffrey b1b2ba6
    PLANNER-421 Avoid undoMove.toString()
@ge0ffrey
  • @ge0ffrey 4bed2e1
    PLANNER-422 Assertion for VariableListener corruption should figure o…
@ge0ffrey
@ge0ffrey
  • @ge0ffrey 5f52b25
    PLANNER-422 Assertion for VariableListener corruption should figure o…
@ge0ffrey
@ge0ffrey
Added ODP file format to gitattributes as binary
1 commit with 1 addition and 0 deletions
@ge0ffrey
@ge0ffrey
Fixed some typos in blog posts
1 commit with 2 additions and 2 deletions
@ge0ffrey
@ge0ffrey
  • @ge0ffrey ce945f0
    PLANNER-413 rename commitMove() to triggerVariableListeners() + docum…
@ge0ffrey
  • @ge0ffrey bc4b84e
    PLANNER-413 rename commitMove() to triggerVariableListeners() + docum…
ge0ffrey commented on pull request droolsjbpm/optaplanner#136
@ge0ffrey

thanks for fixing it quickly :)

@ge0ffrey
ge0ffrey merged pull request droolsjbpm/optaplanner#136
@ge0ffrey
PLANNER-420: Fix
1 commit with 5 additions and 10 deletions
ge0ffrey commented on pull request droolsjbpm/optaplanner#132
@ge0ffrey

2 votes on the same proposal is cheating :) I guess you wanted to use "pro" and "con" and you're +0 on it (which means you're hoping there's a bett…

ge0ffrey commented on pull request droolsjbpm/optaplanner#132
@ge0ffrey

Definitely fail fast if the csv file doesn't exist. Suppose I remove the CSV file manually during benchmark and this method doesn't crash - then I …

ge0ffrey commented on pull request droolsjbpm/optaplanner#132
@ge0ffrey

Should the pointList not be hibernated again after the graph is generated (or a bit later due to the problem statistic stuff)? Otherwise it remains…

ge0ffrey commented on pull request droolsjbpm/optaplanner#132
@ge0ffrey

the name "persist" in not entirely correct. It does more than persist them, it also removes them from memory. What if we call these 2 methods "hibe…

ge0ffrey commented on pull request droolsjbpm/optaplanner#132
@ge0ffrey

Has the Aggregator been manually tested too to assure it doesn't cause any trouble for it?

@ge0ffrey
@ge0ffrey
@ge0ffrey
  • @ge0ffrey bdb6b8c
    Merge pull request #133 from oskopek/PLANNER-284-fix
  • @oskopek a6c3352
    PLANNER-284: Create new scoreLevelToConstraintUndoListenerMap instead…
  • 1 more commit »
ge0ffrey merged pull request droolsjbpm/optaplanner#133
@ge0ffrey
PLANNER-284: Code style + performance
2 commits with 6 additions and 7 deletions
ge0ffrey commented on pull request droolsjbpm/optaplanner#133
@ge0ffrey

I 'll revert the clear() line indeed: if they do heavily use 20 different score levels for 1 match, then the Map capacity will have expanded to 20 …

@ge0ffrey
ge0ffrey merged pull request droolsjbpm/optaplanner#134
@ge0ffrey
Added modules to the maven-checkstyle-plugin
1 commit with 96 additions and 0 deletions
ge0ffrey commented on pull request droolsjbpm/optaplanner#116
@ge0ffrey

I've just seen a javadocs guidelines page that also uses dots there in an example, so looks like you're right :) http://www.oracle.com/technetwork/…

ge0ffrey commented on pull request droolsjbpm/optaplanner#116
@ge0ffrey

Meh. False negatives are very annoying. From practical experience, I believe that any rule which has false negatives needs to be disabled entirely …

@ge0ffrey