Geoffrey De Smet
ge0ffrey

Organizations

@droolsjbpm @mvel @pressgang
Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

+1. Let's merge this as-is (when other comments are fixed) and then do a separate PR for that change.

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/drools#827
@ge0ffrey

To reproduce run AccumulateTest or any of the others that are failing on Jenkins.

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

Good to merge after: the TestGen prefix is on all classes (as even non-public classes show up on ctrl-n in intellij) an the Config class getters d…

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

Even though it's not public, it does show in ctrl-n in IntelliJ, so let's prefix all classes with TestGen? Visibility doesn't really help there. Th…

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

If this extends IllegalStateException, we can reuse it for any score corruption in the normal ScoreDirectors too. Should be it CorruptedScoreExcept…

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

do not use getter, so it doesn't need to replace null by the default value. I'd use BooleanUtils.isTrue(generateDroolsTestOnError)

Jul 22, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner#202
@ge0ffrey

The getter should return null if it's null. For all Config classes, it's important to distinguish between null (= not filled in) and the default va…

Jul 22, 2016
@ge0ffrey
  • @ge0ffrey 848b0b8
    First prototype of HardSoftScoreConstraintTest
Jul 21, 2016
@ge0ffrey
  • @yurloc 3ced064
    Fix JavaDoc issues (#206)
Jul 21, 2016
ge0ffrey merged pull request droolsjbpm/optaplanner#206
@ge0ffrey
Fix JavaDoc issues
1 commit with 17 additions and 17 deletions
Jul 20, 2016
ge0ffrey commented on pull request droolsjbpm/jbpm-website#4
@ge0ffrey

@mbiarnes at optaplanner.org I keep an event archive page and only show the upcoming (= future) events on each page. See "archive" link in the even…

Jul 18, 2016
ge0ffrey commented on pull request droolsjbpm/drools#827
@ge0ffrey

This PR fails, probably because of the ClassCastExceptions that are happening. Before we revert those casting and head back to doubleValue() (which…

Jul 15, 2016
@ge0ffrey
  • @ge0ffrey 921d2c2
    PLANNER-482 NonUniqueNotificationVariableListener to forgo unique not…
Jul 15, 2016
@ge0ffrey
  • @ge0ffrey 7949128
    PLANNER-482 NonUniqueNotificationVariableListener to forgo unique not…
Jul 14, 2016
@ge0ffrey
  • @ge0ffrey c4bbded
    PLANNER-478 Replace LinkedList by ArrayDeque wherever appropriate
Jul 14, 2016
ge0ffrey commented on pull request droolsjbpm/drools#836
@ge0ffrey

Take a look at this: http://mvnrepository.com/search?q=xjc (Maven Repository Search Is Your Friend ;) These looks promising: http://mvnrepository.c…

Jul 14, 2016
ge0ffrey commented on pull request droolsjbpm/drools#836
@ge0ffrey

I would supply tips if I had any :). To be solution-oriented: the status-quo is better than introducing a GPL dependency. Maybe it's optimistic, bu…

Jul 14, 2016
@ge0ffrey
  • @ge0ffrey 1fb5ccb
    PLANNER-227 Variables of primitive types should be illegal because Co…
Jul 14, 2016
ge0ffrey commented on pull request droolsjbpm/drools#836
@ge0ffrey

-1 due to use of GPL license dependency... (sorry)

Jul 14, 2016
@ge0ffrey

-1 due to use of GPL license dependency... (sorry)

Jul 13, 2016
@ge0ffrey
  • @ge0ffrey 5472cdb
    PLANNER-227 Variables of primitive types should be illegal because Co…
Jul 13, 2016
@ge0ffrey
  • @ge0ffrey 56a2c98
    PLANNER-227 Variables of primitive types should be illegal because Co…
  • @ge0ffrey 14205fa
    Mention that the deprecated in 7.x api's will be removed in 8.0 (even…
  • 1 more commit »
Jul 13, 2016
@ge0ffrey
  • @ge0ffrey a93f4e9
    PLANNER-383 The deprecated `SolverBenchmarkBluePrintType.ALL_CONSTRUC…
Jul 13, 2016
@ge0ffrey
Jul 13, 2016
@ge0ffrey
  • @ge0ffrey 5ac9ca6
    PLANNER-383 The dead, deprecated code of `DeciderScoreComparatorFacto…
Jul 13, 2016
@ge0ffrey
  • @ge0ffrey ffa44e4
    PLANNER-383 ValueRangeProviders must return a typed Collection.
Jul 13, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner-wb#51
@ge0ffrey

for the record: +1 to merge :)

Jul 13, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner-wb#80
@ge0ffrey

ctrl-shift-f in IntelliJ is your friend when refactoring :) +1 to merge

Jul 13, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner-wb#51
@ge0ffrey

@csadilek Can this be merged or closed?

Jul 13, 2016
ge0ffrey commented on pull request droolsjbpm/optaplanner-wb#79
@ge0ffrey

Implementing the comparator definition in a user friendly way in a UI will prove challenging, this is not a trivial thing to do. Let's discuss tomo…