Skip to content

scope: build properly on GNU/Hurd #146

Closed
wants to merge 4 commits into from

3 participants

@evgeni
evgeni commented Apr 20, 2014

The scope plugin currently does not build on GNU/Hurd. These patches fix the issue by properly detecting BSD flavours (and not misdetecting GNU/Hurd as one) and defining PATH_MAX as GNU/Hurd has no such limitation.

@b4n
Geany member
b4n commented Apr 23, 2014

Shouldn't the configure pass check for libutil.h and util.h and use what's available instead of guessing depending on the platform defines?

@b4n
Geany member
b4n commented Apr 23, 2014

FTR, from IRC:

16:51 < Zhenech> and you actually want to check for pty.h containing openpty(), and fall back to (lib)?util.h if there is none
16:51 < Zhenech> as e.g debians kfreebsd has both, libutil.h and pty.h
16:52 < Zhenech> (but they define compatible interfaces)

@zhekov
Geany member
zhekov commented Apr 25, 2014

Why is GNU/Hurd misdetected as BSD? Does it #define BSD, or what?

If the debugger plugin builds on GNU/Hurd, perhaps I should just include and , and declare unlockpt() and grantpt(), instead of trying to detect 7 different BSD-or-similar.

@zhekov
Geany member
zhekov commented Apr 25, 2014

#include <stdlib.h> and <pty.h>, I wanted to say.

@evgeni
evgeni commented Apr 25, 2014

Yes, it does:

/usr/include/i386-gnu/bits/param.h:#define      BSD     199306          /* System version (year & month). */
@zhekov
Geany member
zhekov commented Apr 25, 2014

So then, can you check if the debugger plugin builds? I have no GNU/Hurd to test on...

@evgeni
evgeni commented Apr 26, 2014

debugger builds fine on Debian GNU/Hurd, yeah.

@zhekov
Geany member
zhekov commented Apr 26, 2014

OK then. I'll try to make the patch tomorrow, it's trivial.

@zhekov zhekov added a commit that referenced this pull request Apr 27, 2014
@zhekov zhekov scope: fix building on GNU/Hurd (PR #146) 1066629
@zhekov
Geany member
zhekov commented Apr 27, 2014

I commited a fix. Please test it, and close this request if it works.

@evgeni
evgeni commented Apr 27, 2014

Yupp, 1066629 builds fine here on GNU/Hurd. Didn't try to run, though, as the machine is remote.

@evgeni evgeni closed this Apr 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.