Debugger #66

Merged
merged 3 commits into from Aug 26, 2012

Conversation

Projects
None yet
3 participants
@cesspit
Member

cesspit commented Aug 24, 2012

  1. removed odd main loop attach call
  2. added new thread group creation message format, that was unhandled previously and caused crash on newer versions of gdb

@ghost ghost assigned frlan Aug 24, 2012

@b4n

This comment has been minimized.

Show comment
Hide comment
@b4n

b4n Aug 25, 2012

Member

33521c8 should be squashed in 24175c1. Otherwise looks good.

Member

b4n commented Aug 25, 2012

33521c8 should be squashed in 24175c1. Otherwise looks good.

@cesspit

This comment has been minimized.

Show comment
Hide comment
@cesspit

cesspit Aug 26, 2012

Member

33521c8 fixes a bug brought in 24175c1, so it's all fine there

Member

cesspit commented Aug 26, 2012

33521c8 fixes a bug brought in 24175c1, so it's all fine there

@b4n

This comment has been minimized.

Show comment
Hide comment
@b4n

b4n Aug 26, 2012

Member

Yes it's ok, I just wanted to suggest that there might be no need for a commit fixing something as trivial just after introducing the issue. But it's fine with 2 commits if you like of course, that's definitely not a blocker.

@frlan ACK & GTG for me then.

Member

b4n commented Aug 26, 2012

Yes it's ok, I just wanted to suggest that there might be no need for a commit fixing something as trivial just after introducing the issue. But it's fine with 2 commits if you like of course, that's definitely not a blocker.

@frlan ACK & GTG for me then.

frlan added a commit that referenced this pull request Aug 26, 2012

@frlan frlan merged commit 13a6056 into geany:master Aug 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment