Skip to content

Commit

Permalink
Drop obsolete 'has_separator' property from the interface definitions
Browse files Browse the repository at this point in the history
  • Loading branch information
@kalikiana @eht16
kalikiana authored and eht16 committed Mar 17, 2013
1 parent a982908 commit 1db4cd9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions data/geany.glade
View file
Expand Up @@ -712,7 +712,6 @@
<property name="modal">True</property>
<property name="type_hint">dialog</property>
<property name="skip_pager_hint">True</property>
<property name="has_separator">True</property>
<property name="icon_name">geany</property>
<child internal-child="vbox">
<object class="GtkVBox" id="dialog-vbox3">
Expand Down Expand Up @@ -6423,7 +6422,6 @@
<property name="destroy_with_parent">True</property>
<property name="type_hint">dialog</property>
<property name="transient_for">window1</property>
<property name="has_separator">True</property>
<property name="icon_name">geany</property>
<child internal-child="vbox">
<object class="GtkVBox" id="project_dialog_vbox">
Expand Down

3 comments on commit 1db4cd9

@b4n
Copy link
Member

@b4n b4n commented on 1db4cd9 Mar 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK why not, but please note that this HAS an impact on the UI, it's not just an harmless bugfix without consequences.

@eht16
Copy link
Member

@eht16 eht16 commented on 1db4cd9 Mar 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I really should have used a more descriptive commit message.

Still, I consider the impact as rather small as it is just the small separator line in the preferences and project preferences dialogs. Probably most users won't even recognise this change while it fixes a bunch of warnings when built against GTK3.

@b4n
Copy link
Member

@b4n b4n commented on 1db4cd9 Mar 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the commit message could have been better, but that's no a problem if you knew it had consequences on the GTK2 UI. And actually I prefer it without the separators I think :)

Please sign in to comment.