Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Update HACKING (#1479)
* Update obsolete references to GLib 2.27/28 in HACKING

Fixes #1476.

* Replace obsolete gcc -W option with -Wextra in HACKING

According to gcc --help=warnings, -W is a deprecated option
and -Wextra should be used instead.
  • Loading branch information
vfaronov authored and elextr committed Apr 25, 2017
1 parent c296efe commit dbcf456
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions HACKING
Expand Up @@ -176,7 +176,7 @@ libs (including GLib, GDK and Pango) has the advantages
that you don't get confused by any newer API additions and you
don't have to take care about whether you can use them or not.

You might want to pass the ``-DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_28`` C
You might want to pass the ``-DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32`` C
preprocessor flag to get warnings about newer symbols from the GLib.

On the contrary, you might also want to get deprecation warnings for symbols
Expand All @@ -196,7 +196,7 @@ Coding
them down into smaller static functions where possible. This makes code
much easier to read and maintain.
* Use GLib types and functions - gint not int, g_free() not free().
* Your code should build against GLib 2.27.3 and GTK 2.24. At least for the
* Your code should build against GLib 2.32 and GTK 2.24. At least for the
moment, we want to keep the minimum requirement for GTK at 2.24 (of
course, you can use the GTK_CHECK_VERSION macro to protect code using
later versions).
Expand All @@ -212,7 +212,7 @@ Compiler options & warnings
Use ``CFLAGS='-Wfoo' ./configure`` or ``CFLAGS='-Wfoo' ./autogen.sh``
to set warning options (as well as anything else e.g. -g -O2).

* Enable warnings - for gcc use '-Wall -W' (and optionally
* Enable warnings - for gcc use '-Wall -Wextra' (and optionally
-Wno-unused-parameter to avoid unused parameter warnings in Glade
callbacks).
* You should try to write ISO C99 code for portability, so always
Expand Down

0 comments on commit dbcf456

Please sign in to comment.