Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 25, 2015
  1. @eht16
Commits on Aug 24, 2015
  1. @b4n
Commits on Aug 23, 2015
  1. @b4n

    Merge pull request #469 from kugel-/new_hooks

    b4n authored
    Plugin loader redesign
  2. @b4n
  3. @kugel-

    plugins: Clarify which API functions may be called within geany_load_…

    kugel- authored
    …module()
    
    Since geany_load_module() is called for non-enabled plugins you may not
    use the plugin API here yet. The only exceptions to this rule are API functions
    required for plugin registration.
    
    This rule is hard to enforce (would need to g_return_if_val(PLUGIN_LOADED_OK(p))
    for all API functions (well, those taking a plugin pointer anyway), so this
    rule is only documented for now.
  4. @kugel-

    plugins: separate geany_plugin_set_data() dual-use

    kugel- authored
    It was found that because geany_plugin_set_data() could be used by both
    plugin's init() and geany_load_module(), that it introduced some uncertainty
    as to when to call the free_func. init() callers might expect the call
    around the same time as cleanup() is called, while geany_load_module()
    callers expected the call at module unload time.
    
    It was indeed called at module unload time. But that means that init() callers
    cannot call it again reliably after in a init()->cleanup()->init() flow (when
    toggling the plugin) without fully unloading the plugin (which is what we do
    currently but that's we would want to change).
    
    With the separation we can actually destroy the data depending on where
    it was set and do everything unambigiously.
  5. @kugel-

    plugins: Updated doxygen for the new plugin loader

    kugel- authored
    The documentation provides a quite detailed description of the new loader
    In addition it adds a "how to transition" that briefly describes the old
    loader (for curious newcomers) and lots of hints for porting legacy
    plugins to the new loader.
  6. @kugel-

    plugins: Pass pdata to PluginCallback function by default

    kugel- authored
    If the plugin did not set its own user_data we set it to whatever it set
    with geany_plugin_register_full() or geany_plugin_set_data().
    This is particularly convinient because PluginCallback is usually statically
    allocated, at which point dynamically allocated plugin data doesn't exists yet.
  7. @kugel-

    plugins: change return codes of geany_load_module() and GeanyPluginFu…

    kugel- authored
    …ncs::init
    
    - The return value from geany_load_module is removed (void). It was ignored
      anyway and we have to check separately whether the plugin loaded OK or not
      anyway. If the plugin specific code fails it should simply not call
      geany_plugin_register() (which it should only call iff all other conditions
      are good).
    
    - GeanyPluginFuncs::init() now returns a bool to allow failing initialization.
      Some plugins might want to defer work to their init() (i.e. only do
      it when the plugin was activated by the user), and some of that work can
      possibly fail (e.g. GtkBuilder fails to load .xml).
    
    Note that the GUI integration of the latter is less than ideal but this kind
    of GUI/policy work is out of scope for this patch set. Therefore a plugin
    failing to init is simply removed from the PM dialog as if it became
    incompatible. However, as the code that generates the list does not call init
    they will show up again if the PM dialog is re-opened.
  8. @kugel-

    demoplugin: Adapt demoplugin to the new loader

    kugel- authored
    Demoplugin, while not installed by default, is a nice starting point
    and mini-howto. Therefore it should advertise the new loader from the
    beginning.
  9. @kugel-

    plugins: Refactor legacy plugin support

    kugel- authored
    With geany_plugin_set_data() the legacy plugin support can be made
    more transparent by using wrapper functions that call the actual plugin_*
    functions. This allows to remove the differentiation in code that's not
    directly concerned with actually loading plugins.
    
    This commit doesn't change anything except for one thing: legacy plugins now
    cannot call geany_plugin_set_data(). But it is meant for new-style plugins
    anyway.
  10. @kugel-

    plugins: Replace geany_plugin_register() pdata with a separate API fu…

    kugel- authored
    …nction
    
    The API function adds a free_func parameter, and can also be called
    after geany_plugin_register(), i.e. in the plugin's init() callback. This
    fixes a by-design memory leak and gives greater flexibility.
  11. @kugel-

    plugins: Let plugins fill GeanyPlugin::callbacks instead of passing t…

    kugel- authored
    …heir own pointer
    
    This is easier to handle if we decide to add callbacks. Since we can
    zero-initialize callbacks before passing it to the plugin we can be certain as
    to which callbacks the plugin knew about when it was compiled. This is exactly
    the same method used for GeanyPlugin::info already and easier than inspecting
    the API version.
  12. @kugel-

    plugins: plugin loader redesign

    kugel- authored
    The old plugin loader has a number of deficiencies:
    
    - plugins need to export a couple of callback functions into the global namespace
    - plugins need to export data pointers, that are written by Geany
    - the exported functions have no user_data param, so there is no way to
      pass context/state back to the plugin (it needs global storage for that)
    - plugin registration is implicit, plugins have no way to not register themselves
      (it may want that due to missing runtime dependencies)
    - plugins perform the ABI/API verification, and even though we provide a
      convinience wrapper, it may get that wrong
    
    As a result, I designed a new loader with the following design principles
    - semantics of callbacks should not change, but they they shouldn't be mess
      with the global namespace
    - each callback receives a self-identifying param (the GeanyPlugin instance) and
      a plugin-defined data pointer for their own use
    - explicit registration through a new API function
    - in-core API/ABI checks
    
    The following principles shall be left unchanged:
    - The scan is done on startup and when the PM dialog is opened
    - Geany allocates GeanyPluginPrivate for each plugin, and GeanyPlugin is
      a member of it
    - Geany initially probes for the validity of the plugin, including file type
      and API/ABI check, thus Geany has the last word in determining what a
      plugin is
    - the PM dialog is updated with the proper, translated plugin information
    - the PM dialog GUI and user interaction in general is unchanged
    
    With the redesign, plugins export a single function: geany_load_module().
    This is called when the GModule is loaded. The main purpose of this function
    is to call geany_plugin_register() (new API function) to register the plugin.
    This is the only function that is learned about through g_module_symbol().
    Within this call the plugin should
    a) set the localized info fields of GeanyPlugin::info
    b) pass compiled-against and minimum API version as well as compiled-against
       ABI version, to allow Geany to verify compatibility
    c) pass a pointer to an instance of GeanyPluginFuncs
       which holds pointers to enhanced versions of the known callbacks (except
       configure_single which is dropped).
    d) optionally pass a plugin-private data pointer for later callbacks
    
    Enhanced means that all callbacks receive the GeanyPlugin pointer as the first
    and a pdata pointer as the last. pdata is private to the plugin and is set
    by geany_plugin_register().
    
    The callbacks need (should) not be globally defined anymore, and the global
    GeanyData, GeanyPlugin and GeanyFunctions pointers are ignored and not set
    anymore. GeanyData is available through GeanyPlugin::geany_data.
Commits on Aug 22, 2015
  1. @SiegeLord
  2. @SiegeLord

    Parse 'where' bounds correctly.

    SiegeLord authored SiegeLord committed
  3. @SiegeLord

    Update Rust keywords.

    SiegeLord authored SiegeLord committed
Commits on Aug 21, 2015
  1. @b4n

    Merge pull request #394 from SiegeLord/selection_document_mods

    b4n authored
    Make Document > Strip trailing spaces/Replace tabs/Replace spaces use
    the current selection.
Commits on Aug 16, 2015
  1. @b4n @SiegeLord

    Keep selection stable when replacing tabs and spaces

    b4n authored SiegeLord committed
  2. @SiegeLord
  3. @SiegeLord

    Document the changes to space/tab replacement

    SiegeLord authored SiegeLord committed
  4. @SiegeLord

    Use current selection when replacing tabs/spaces from the menu.

    SiegeLord authored SiegeLord committed
    When saving the file, the tabs are removed from the whole file as usual.
  5. @SiegeLord

    Use current selection when stripping trailing whitespace from the menu.

    SiegeLord authored SiegeLord committed
    When the lines are stripped due to the file being saved, ignore the selection.
Commits on Aug 6, 2015
  1. @frlan

    Update of Swedish translation

    frlan authored
Commits on Aug 5, 2015
  1. @dmaphy

    Merge pull request #599 from oliwer/perlkeywords

    dmaphy authored
    Add new keywords for recent versions of Perl
  2. @oliwer

    Add new keywords for recent versions of Perl

    oliwer authored
    This commit adds the following new keywords for perl:
     - say
     - state
     - given, when, default
     - __SUB__
    
    While __SUB__ was introduced in perl 5.16, the others date back
    to v5.10 released in 2007!
Commits on Aug 4, 2015
  1. @codebrainz
Commits on Jul 31, 2015
  1. @waynenilsen @codebrainz

    Use Cargo tool for Rust build commands

    waynenilsen authored codebrainz committed
    Closes PR #557
Commits on Jul 22, 2015
  1. @b4n

    Merge pull request #574 from eht16/doxygen_fixes

    b4n authored
    Fix Doxygen warnings
  2. @eht16

    Merge pull request #583 from eht16/win32_fix_native_dialogs

    eht16 authored
    Windows: restore modern design of native file dialogs
  3. @eht16

    Fix Doxygen warnings

    eht16 authored
    This resolves warnings from Doxygen about non-existing commands
    caused by unescaped backslashes as well as multiply
    defined section names.
  4. @eht16

    Merge pull request #573 from zhekov/cleanup-win32defines

    eht16 authored
    Cleanup win32defines
Commits on Jul 21, 2015
  1. @eht16

    Merge pull request #585 from codebrainz/remove-style-debug-print

    eht16 authored
    Remove needless debug print
  2. @codebrainz

    Remove needless debug print

    codebrainz authored
    Prevents spamming the console when SCLEX_CONTAINER
    is activated (ex. by plugins).
Commits on Jul 19, 2015
  1. @eht16

    Windows: restore modern design of native file dialogs

    eht16 authored
    This restores the previously used "modern design" of the Windows
    native file open/save dialogs. Also make the dialogs resizable.
    
    Fixes #578.
Something went wrong with that request. Please try again.