Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Windows installer to NSIS 3.x #1302

Closed
eht16 opened this issue Nov 13, 2016 · 11 comments · Fixed by #2181

Comments

@eht16
Copy link
Member

commented Nov 13, 2016

NSIS 3.0 is out for a while and there are MSYS2 packages for NSIS 3.x which would make the release process on Windows easier.

@eht16 eht16 added the windows label Nov 13, 2016
@eht16 eht16 added this to the 1.30 milestone Nov 13, 2016
@eht16 eht16 self-assigned this Nov 13, 2016
@elextr

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

@eht16 is this gonna be your last minute windows change for 1.30 or should we move the milestone to 1.31? 😉

@eht16 eht16 modified the milestones: 1.31, 1.30 Mar 1, 2017
@eht16

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

As tempting as it is, I think I can resist this time :).

@kugel- kugel- modified the milestones: 1.31, 1.34 Apr 3, 2018
@kugel-

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

@eht16 What about this?

@eht16

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2018

We should still port the installer to NSIS 3. This would also ease creating full installers from the nightly builds as NSIS 3 is available as Debian package (not tested but might work to build full installers from nightly builds).

Though it is unlikely I will work on this myself in the next months.

@b4n

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

@eht16 should I move that to 1.35 milestone?

@eht16 eht16 modified the milestones: 1.34, 1.35 Dec 2, 2018
@eht16

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2018

Did it myself, thanks for reminding me.

@b4n

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Once more? :)

@elextr

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Just move it to Geany 5.0 :-P

@eht16

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

Come on, this is only 2.5 years old :)

I still like to get this done (not necessarily by myself) as then we can build the installer from within the MSYS2 environment which eases the release process. And it might even help to cross-build the installer in some more far future.

@b4n b4n modified the milestones: 1.35, 1.36 Apr 28, 2019
@b4n

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Sound great, but I'll still move it one milestone forward :)

eht16 added a commit to eht16/geany that referenced this issue Jun 10, 2019
@eht16

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@b4n I know you didn't believe this will ever happen but here we are: #2181.

The migration of the installer script was way easier than expected, I just had to start doing it :).
As a bonus, I added a script to update the keywords in the NSIS filetype definition.

Sometime before 1.36, I will update the G-P installer as well.

@eht16 eht16 closed this in #2181 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.