Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters appear in the text when pressing alt+page_down having the cursor outside the line #2066

Closed
HybridDog opened this issue Jan 25, 2019 · 10 comments

Comments

Projects
None yet
3 participants
@HybridDog
Copy link

commented Jan 25, 2019

I noticed that when I set the cursor right of the line end (ctrl and click), and then press alt+page_down to swap the line with the next one, strange characters appear. I use geany 1.33 (built on 2018-04-16 with GTK 3.22.30, GLib 2.56.1) on Lubuntu 18.04.

2019-01-25-154310_1920x1056_scrot
2019-01-25-154328_1920x1056_scrot

@HybridDog HybridDog changed the title Strange bytes suddenly appear in the text Characters appear in the text when pressing alt+page_down having the cursor outside the line Jan 25, 2019

@elextr

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

Can't reproduce on

10:37:53: Geany INFO		: Geany 1.35 (git >= 4452b36), en_AU.UTF-8
10:37:53: Geany INFO		: GTK 3.18.9, GLib 2.48.2
@elextr

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@HybridDog how big is your file? See #2076.

@HybridDog

This comment has been minimized.

Copy link
Author

commented Feb 5, 2019

My file is quite small. I don't know if it's fixed in a newer version of geany; when I created the Issue, I thought that lubuntu 18.04 still has the newest stable version.

@elextr

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

@HybridDog I don't suppose you can share your file for us to test with? Also what filetype is it?

The latest Geany release is 1.34.1 which came out well after 18.04.

@b4n

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

I just reproduced this in a quite small patch file. I couldn't reproduce it twice, but it definitely happened to me a minute ago (1.35 ≥ c825b58, GTK 3.24.4, GLib 2.58.2).

@elextr

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

So, since I have never seen it, its an intermittent bug in GTKs newer than 3.18.9, that should be easy to find, not. 😈

@HybridDog

This comment has been minimized.

Copy link
Author

commented Feb 5, 2019

I don't suppose you can share your file for us to test with? Also what filetype is it?

It happens everywhere, not only with a specific file. I've also tried it with the default configuration for me, it still happened.

@b4n

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

OK I should have noticed the OP edition (unfortunately mails don't show them…). Actually, it happens reliably (under with rectangular selection, or possibly any kind of non-stream selection. There's invalid memory manipulation inside Scintilla's SCI_MOVESELECTEDLINESDOWN/UP.

@b4n

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@b4n b4n added scintilla bug and removed can't reproduce labels Feb 7, 2019

@b4n b4n closed this in d551765 Apr 27, 2019

@b4n b4n self-assigned this Apr 27, 2019

@b4n b4n added this to the 1.35 milestone Apr 27, 2019

@b4n

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Imported upstream fix. Now moving lines with a rectangular selection will not do anything. It's not perfect, but it way better than invalid memory access and messing up the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.