Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling language files in Windows installer doesn't affect Gtk localizations #2090

Closed
danpla opened this issue Feb 19, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@danpla
Copy link

commented Feb 19, 2019

The "Language Files" option of the Windows' installer only disables language files for Geany, but not for Gtk runtime. As a result, the installation takes 68.7 MB, 33.5 MB (49%) of which are MO files of Gtk in "share/locale" folder. However, the real issue is not the disk space but the fact that the interface becomes partially translated.

The same problem is with the installer for plugins.

@eht16

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Yes, this is some sort of intended because it is not that easy to seperate the GTK stack translations from the rest and so I decided to just live with it, especially as disk space is not a real problem nowadays.

But I didn't really realise the other mentioned problem: partially translated interface. This is in fact quite bad. I might work on this at some point but would be happy if anyone likes to contribute a patch.

@eht16 eht16 added windows bug labels Mar 3, 2019

eht16 added a commit to geany/geany-plugins that referenced this issue Apr 22, 2019

@eht16 eht16 closed this in 1223743 Apr 22, 2019

@eht16

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

It turned out it was actualy quite easy to solve.

The only drawback is that now GTK/dependency translations will be installed if translations are selected but GTK runtime/dependencies are not selected. Hope that's ok.
Preventing this is possible but would require quite some logic and more code in the installer for a probably uncommon combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.