Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed notebook tab switching by keyboard shortcut #108

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

When you choose to hide any of the tabs in the various UI components, such as unchecking "Preferences->Interface->Sidebar->Show documents list" or unchecking the various "_visible" preferences in Preferences->Various, the hidden tab prevents the keybindings for "Switch to left document" and "Switch to right document".

This fixes the bug so that it ignores non-visible tabs and still switches with wrapping.

Tested on:
geany 1.23 (git >= db8e198) (built on Feb 20 2013 with GTK 2.24.4, GLib 2.28.6)

elextr commented on df0d332 Feb 21, 2013

Since you no longer use cur_page and page_count you should remove them to avoid "set but not used" warnings

Owner

sblatnick replied Apr 16, 2013

page_count is still used on line 1700 and cur_page is still used on lines 1693 and 1700.

They are still used, on the if statement.

Anything else I should do here?

Member

elextr commented Apr 6, 2013

On 7 April 2013 08:33, sblatnick notifications@github.com wrote:

Anything else I should do here?

Well, the actual focus keybindings are set in prefs, not hard-coded, should
this use whatever the preference setting is?


Reply to this email directly or view it on GitHubhttps://github.com/geany/geany/pull/108#issuecomment-16005416
.

I think you intended this comment for #107 and not this one. I'll post a comment in that one with your remarks.

Let me know if there is something else I need to do for this full request. (As stated in an earlier comment, the variables cannot be removed since it's still used in the statements surrounding the changes.)

Owner

b4n commented May 9, 2013

Your implementation has a bug, it doesn't fix the case where the first or last page are hidden. I implemented the fix otherwise in deede05, by manually checking whether the page is visible, and if not continue searching. But anyway, thanks a lot for the catch and your work on it.

@b4n b4n closed this May 9, 2013

Thanks for catching that bug. My bad.

On 05/09/2013 04:23 PM, Colomban Wendling wrote:

Your implementation has a bug, it doesn't fix the case where the first
or last page are hidden. I implemented the fix otherwise in deede05
deede05,
by manually checking whether the page is visible, and if not continue
searching. But anyway, thanks a lot for the catch and your work on it.


Reply to this email directly or view it on GitHub
#108 (comment).

@b4n b4n self-assigned this Aug 1, 2014

@b4n b4n added the Bug label Aug 1, 2014

@b4n b4n added this to the 1.24.0 milestone Aug 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment