Make prompt dialogs explicitly modal #152

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

elextr commented Jul 8, 2013

dialogs.c:show_prompt() uses dialog_run which acts as modal on GTK
based window systems because it uses a recursive mainloop, but
appears to not do so on KDE or Unity window systems. See Bug #976.
Explicitly setting the modal flag as well may be honoured by those
systems.

This PR is to let the OP test it first on KDE and Unity.

@elextr elextr Make prompt dialogs explicitly modal
dialogs.c:show_prompt() uses dialog_run which acts as modal on GTK
based window systems because it uses a recursive mainloop, but
appears to not do so on KDE or Unity window systems (see Bug #976).
Explicitly setting the modal flag as well may be honoured by those
systems.
feb7c20
Owner

codebrainz commented Jul 8, 2013

FWIW, it gets set modal either way.

Maybe we need to call gtk_window_set_transient_for (if we don't already, didn't look).

Member

elextr commented Jul 8, 2013

On 8 July 2013 14:29, Matthew Brush notifications@github.com wrote:

FWIW, it gets set modal either wayhttps://git.gnome.org/browse/gtk+/tree/gtk/gtkdialog.c#n1047
.

Worth a try though, who knows what the recidivist desktops do :)


Reply to this email directly or view it on GitHubhttps://github.com/geany/geany/pull/152#issuecomment-20585189
.

Owner

codebrainz commented Aug 15, 2013

We decided to close this because no-one who uses KDE could confirm. If anyone thinks this is the fix or has better solution, feel free to re-open, comment, or send a message on the mailing list to get it working or re-opened.

codebrainz closed this Aug 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment