Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scintilla to version 3.10.2 #2045

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@b4n
Copy link
Member

commented Jan 12, 2019

Closes #971, closes #1947.

@b4n b4n added the scintilla label Jan 12, 2019

@b4n b4n added this to the 1.35 milestone Jan 12, 2019

@b4n

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

@BenWiederhake could you test this and see if it indeed fixes the 2 markdown issues mentioned above?
I'm confident it fixes #1947, but I couldn't exactly reproduce #971 as you described it, so I'm not totally certain that very occurrence of it is fixed.

@elextr

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

@b4n, That was fast, well done. WFM so far.

Hope it didn't stop you from reviewing @techee's ctags PR 😁

@BenWiederhake

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

Before

geany 1.33 (built on 2018-04-16 with GTK 3.22.29, GLib 2.56.1)
#971: Yes, can reproduce it, but file must be recognized as Markdown (e.g., save as "blahblah.md")
#1947: Yes, can reproduce it, exactly as described.

After

(I checked that at least "scintilla/include/Platform.h" contains the changes.
cat scintilla/version.txt says 3102.
The Debian patches seem mostly cosmetic for my purpose.
Building with "auto" fails, wants gtk2-dev libs, complains about symbols and version mixing.
./configure --disable-html-docs --enable-gtk3 && make -j4 && sudo make install
Success.)
geany 1.35 (git >= ecf98b1) (built on 2019-01-13 with GTK 3.24.2, GLib 2.58.2)
#971: No, can't reproduce it: Correct (fixed) initial state, and correct (fixed) behavior when pressing enter. Looks fixed to me.
#1947: No, can't reproduce it: Correct (fixed) initial state, and correct (fixed) behavior when deleting a character. Looks fixed to me.

Less than 24 hours after the scintilla version appeared!
Thank you for your quick work! :)

@b4n b4n merged commit ecf98b1 into geany:master Jan 13, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@b4n

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2019

@BenWiederhake thanks for the detailed check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.