Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nim filetype #2085

Merged
merged 6 commits into from Jun 8, 2019

Conversation

@trustable-code
Copy link
Contributor

commented Feb 7, 2019

Add support for the Nim programming language using the Python lexer.
Nim website: https://nim-lang.org/

Additional notes:
PR #193 is another PR for Nim support. That one has an own lexer. "Nimrod" is the old name of the language.

Add support for the Nim programming language using the Python lexer.
Nim website: https://nim-lang.org/
@trustable-code trustable-code referenced this pull request Feb 7, 2019
@elextr

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

The filetypes file filename has the wrong form for a custom filetype I'm surprised it worked.

@trustable-code

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

@elextr Thanks. Now it should be correct.

Copy link
Member

left a comment

Looks reasonable, but do we want Nim builtin? I don't mind, but for not very widespread languages that only need/have a custom filetype, we often just have a wiki page. However, if the filetype is of sufficient quality I guess we can have it in, especially as I read a few mentions of Nim lately here and at Universal-CTags so it might be gaining popularity.

data/filedefs/filetypes.Nim.conf Outdated Show resolved Hide resolved
data/filedefs/filetypes.Nim.conf Show resolved Hide resolved
data/filedefs/filetypes.Nim.conf Show resolved Hide resolved
@elextr

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

@b4n, a quick survey shows Nim doesn't make it near the top of any of the programming language rankings, its no typescript or coffeescript or other high profile JS languages (as flawed these lists are, not making any is likely significant).

But whilst in the past I have also tended to suggest the wiki I have sort of changed my mind a bit, really should Geany (or other tools) be picking winners, especially when it is only a filetypes.XXX.conf file. Its unlikely to need much support effort at that level.

Certainly more heavily integrated languages with lexers and parsers that need more support should be considered carefully, but one config file seems low impact.

However as there are already too many programming languages, maybe we need another group in filetypes.extensions, but thats another issue (#2087 actually :).

As requested by b4n
@trustable-code

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@b4n Thanks. I have removed the unneeded things as you have requested. I kept the line "type=0" because Nim does not allow tabulators.

@qqtop

This comment has been minimized.

Copy link

commented Jun 4, 2019

Hope this can be merged any time soon now.

data/filedefs/filetypes.Nim.conf Outdated Show resolved Hide resolved
@ntrel

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Thanks @trustable-code. If you have time to fix the %e issue, that would be great. Otherwise I could fix it later and merge. @b4n's comments all seem to be resolved now (Nim rejects tabs).

@trustable-code

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@ntrel The PR is now updated.

@ntrel ntrel merged commit 3afdba5 into geany:master Jun 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
This was referenced Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.