Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the shell if VTE restart is requested #2116

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@eht16
Copy link
Member

commented Mar 31, 2019

This happened in the past until d35e664
because of https://sourceforge.net/p/geany/bugs/163/ and
https://bugzilla.gnome.org/show_bug.cgi?id=540161.
But since the VTE bug has been fixed for long, we can remove the
workaround.

Closes #352.

Restart the shell if VTE restart is requested
This happened in the past until d35e664
because of https://sourceforge.net/p/geany/bugs/163/ and
https://bugzilla.gnome.org/show_bug.cgi?id=540161.
But since the VTE bug has been fixed for long, we can remove the
workaround.

Closes #352.
@b4n

b4n approved these changes Apr 27, 2019

Copy link
Member

left a comment

Not sure why we need to kill the child, but this works for me for correcting the issue. I would have though the child-exited handler should do all what is needed, but well.

FTR, I can reproduce seeing "weird behavior" of the directory following feature after restarting the terminal. I say weird because it stops working with some directories, maybe the one in which it was when it got restarted or something? I didn't investigate far enough but it looks reasonable when looking at the code.

@eht16

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

If you find more details about the weird behaviour, let's create a new issue.
I wasn't able to break it again with this change.

Ok to merge for 1.35?

@b4n b4n added this to the 1.35 milestone Apr 28, 2019

@b4n

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

If you find more details about the weird behaviour, let's create a new issue.
I wasn't able to break it again with this change.

me neither, it worked fine with the fix, but I can't say I tested it for months either :)

Ok to merge for 1.35?

Yes

@eht16 eht16 merged commit 12f03f6 into geany:master Apr 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eht16 eht16 deleted the eht16:issue352_vte_full_restart branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.