Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COBOL: Import new upstream candidate parser #2128

Merged
merged 1 commit into from Apr 27, 2019

Conversation

@b4n
Copy link
Member

commented Apr 20, 2019

This fixes support for COBOL symbols after the recent breakage of regex
parsers, as well as introducing additional features and bug fixes.

Also import some of the tests.

universal-ctags/ctags#2076

Part of #2119.

COBOL: Import new upstream candidate parser
This fixes support for COBOL symbols after the recent breakage of regex
parsers, as well as introducing additional features and bug fixes.

Also import some of the tests.

universal-ctags/ctags#2076

Part of #2119.

@b4n b4n added this to the 1.35 milestone Apr 20, 2019

@b4n b4n requested review from techee and elextr Apr 20, 2019

@b4n

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

@DansLeRuSH (and @swconnolly if still have interest in Geany COBOL support), could you give this a test? It should bring back COBOL symbols, and improve it a bit.

Note that if you'd like to help to get it even further with actual COBOL insight, please comment on universal-ctags/ctags#2076.

@elextr

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

WFM, compiles, runs, make checks, shows symbols for bits of cobol found in wikipedia.

@elextr elextr referenced this pull request Apr 20, 2019

Open

Upstream or alternative solution for ctags regex parsers #2119

2 of 2 tasks complete
@elextr

elextr approved these changes Apr 20, 2019

Copy link
Member

left a comment

LGTM, didn't review the parser itself as the only Cobol I ever did was one assignment in Uni [mumble] years ago.

@b4n

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

didn't review the parser itself as the only Cobol I ever did was one assignment in Uni [mumble] years ago.

Still better than me who wrote the parser, with zero COBOL experience :)

@elextr

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Still better than me who wrote the parser, with zero COBOL experience :)

Yesterday @b4n couldn't spell COBALL, now he am an expert :)

@elextr

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Still better than me who wrote the parser, with zero COBOL experience :)

Yesterday @b4n couldn't spell COBALL, now he am an expert :)

In fact probably the expert in the Geany team I suspect.

@codebrainz

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Nice work @b4n.

@techee

techee approved these changes Apr 24, 2019

Copy link
Member

left a comment

So yeah, to properly review this pull request I'd have to learn cobol, which I'm not going to do (got scared enough by seeing some examples online). I've just skimmed through the code and didn't find anything obviously bad about it, noticed the author is @b4n, which is a guarantee of quality by itself, so I approve this commit.

@b4n See? This is how you do commit reviews. You should learn from me, it's trivial :-)

@b4n b4n self-assigned this Apr 27, 2019

@b4n

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

@b4n See? This is how you do commit reviews. You should learn from me, it's trivial :-)

Wow, why did I use to put so much effort and time if it's so easy! thanks 😄

@b4n b4n merged commit 585b16b into geany:master Apr 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

b4n added a commit that referenced this pull request Apr 27, 2019

Merge pull request #2128 from b4n/ctags/new-cobol-parser
COBOL: Import new upstream candidate parser
@DansLeRuSH

This comment has been minimized.

Copy link

commented Apr 27, 2019

Truly I work with this (and no, I do not only code in COBOL) and adjust it every time I could. @b4n told me interesting suggestions and I'll do upgrades later

@b4n

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

@DansLeRuSH don't hesitate to mention any issue you find, I'm happy to try and fix them or review a patch. If you can, ideally you'd report it what can be against universal-ctags, but don't worry if it's against Geany I can forward what need be just fine as well.

@swconnolly

This comment has been minimized.

Copy link

commented Apr 30, 2019

Hello all. Sorry for arriving late, I was on vacation. Parsing sure looks different from previously. The new parser looks good, especially multi-level data items. Attached is a patch with a few tweaks . They deal with binary data items that do not have either a PIC or VALUE clause and special keywords showing up as procedures.
At we work mostly with free format files. Is there a way to switch from FIXED to FREE? Otherwise I will code the change and recompile.
geany_cobol.patch.txt

@b4n b4n added this to Parsers in U-CTags sync Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.