COBOL: Import new upstream candidate parser #2128
referenced this pull request
Apr 20, 2019
techee left a comment
So yeah, to properly review this pull request I'd have to learn cobol, which I'm not going to do (got scared enough by seeing some examples online). I've just skimmed through the code and didn't find anything obviously bad about it, noticed the author is @b4n, which is a guarantee of quality by itself, so I approve this commit.
@b4n See? This is how you do commit reviews. You should learn from me, it's trivial :-)
Apr 27, 2019
1 check passed
@DansLeRuSH don't hesitate to mention any issue you find, I'm happy to try and fix them or review a patch. If you can, ideally you'd report it what can be against universal-ctags, but don't worry if it's against Geany I can forward what need be just fine as well.
Hello all. Sorry for arriving late, I was on vacation. Parsing sure looks different from previously. The new parser looks good, especially multi-level data items. Attached is a patch with a few tweaks . They deal with binary data items that do not have either a PIC or VALUE clause and special keywords showing up as procedures.