Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't perform line breaking in rectangular selection mode #2135

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@b4n
Copy link
Member

commented Apr 27, 2019

Doing so drops the rectangular selection, and there is no obvious correct behavior for line breaking with a rectangular selection. So, just don't do line breaking in this case.

Fixes #2051.

@elextr please test :)

Don't perform line breaking in rectangular selection mode
Doing so drops the rectangular selection, and there is no obvious
correct behavior for line breaking with a rectangular selection.
So, just don't do line breaking in this case.

Fixes #2051.

@b4n b4n added the bug label Apr 27, 2019

@b4n b4n added this to the 1.35 milestone Apr 27, 2019

@b4n b4n requested a review from elextr Apr 27, 2019

@elextr

elextr approved these changes Apr 27, 2019

Copy link
Member

left a comment

Makes sense and seems to fix the crash, but still concerned about why the crash was intermittent, maybe my testing of this didn't hit it.

Anyway even if not perfect is sensible approved and merged

@elextr elextr merged commit f6b0448 into geany:master Apr 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.