Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the GTK/GLib versions in about dialog #2163

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@codebrainz
Copy link
Member

commented May 24, 2019

The idea is to make it easier and more obvious how to get the runtime GTK+/GLib versions. I'm not sure it adds much over the Debug Messages window except that the textbox can get quite long to scroll and its contents can be cleared.

Since I already made the patch, I figured I'd add a PR for it.

It looks like this:

about_gtk_glib_versions

If we want this, it might be nice to reformat the (built on or after <date>) line to look more like a normal sentence like in this PR.

Feel free to close, I'm rather indifferent on it.

@codebrainz codebrainz self-assigned this May 24, 2019
@kugel- kugel- marked this pull request as ready for review Aug 6, 2019
@kugel-

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Tested and works fine. One could argue that this information could be expected directly under the Geany version but gets the job done just as well.

@kugel- kugel- self-requested a review Aug 6, 2019
@kugel-
kugel- approved these changes Aug 6, 2019
@kugel-

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@codebrainz feel free to merge or should someone else do it?

@codebrainz codebrainz merged commit c29bf20 into geany:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.