Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow user filetype extensions to override system config file #2166

Merged
merged 2 commits into from Jun 10, 2019

Conversation

@ntrel
Copy link
Member

commented May 30, 2019

Before the user would sometimes have to override UnwantedFiletype= in the user config file to remove an extension written in the system file. Geany would ignore an overridden filetype in the user config file that also matches the extension. This happened when the wanted filetype had a higher index than the unwanted one in filetypes_array.

This also first refactors the code without filetypes_find (which I wrote ages ago) - It's not worth abstracting finding through filetypes_array, it's not bug prone, and it may even cause bugs with non-type-safe predicate signature. It was only used once anyway.

ntrel added 2 commits May 16, 2019
It's not worth abstracting finding through filetypes_array, it's not bug prone,
and it may even cause bugs with non-type-safe predicate signature. It was only
used once anyway.
Before the user would sometimes have to override 'UnwantedFiletype=' in
the user config file to remove an extension written in the system file.
Geany would ignore an overridden filetype in the user config file that
also matches the extension. This happened when the wanted filetype had a
higher index than the unwanted one in filetypes_array.
@ntrel

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

Note that #2167 changes the logic again, so you might rather just review that ;-)

@ntrel ntrel merged commit 770cda4 into geany:master Jun 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ntrel ntrel deleted the ntrel:user-ft-ext branch Jun 10, 2019
@ntrel

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Oops, I should have chosen rebase and merge, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.