Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS upgrade to 3.x #2181

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@eht16
Copy link
Member

commented Jun 10, 2019

Also update keywords for the NSIS filetype and add a script to do the update work for us.

Closes #1302.

@b4n
b4n approved these changes Jun 19, 2019
Copy link
Member

left a comment

Apart from the 2 comments that I'm sure are nothing, I have nothing else to say, as I don't know much of it and trust you on this :)

scripts/update-nsis-functions.sh Outdated Show resolved Hide resolved
data/filedefs/filetypes.nsis Show resolved Hide resolved
Copy link
Member

left a comment

Apart from the one comment, LGTM

scripts/update-nsis-functions.sh Outdated Show resolved Hide resolved
@b4n
b4n approved these changes Jun 20, 2019
scripts/update-nsis-functions.sh Outdated Show resolved Hide resolved
@b4n
b4n approved these changes Jun 23, 2019
Copy link
Member

left a comment

Nitpicking below, otherwise looks good 👍

scripts/update-nsis-functions.sh Outdated Show resolved Hide resolved
@b4n
b4n approved these changes Jul 5, 2019
And add a script to make this task easier in the future.
@eht16 eht16 force-pushed the eht16:nsis_upgrade branch from 81c370e to 3820a4f Jul 6, 2019
@eht16 eht16 merged commit aa54866 into geany:master Jul 6, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@eht16 eht16 deleted the eht16:nsis_upgrade branch Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.