Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin custom filetype from github.com/esotericpig #2186

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@ntrel
Copy link
Member

commented Jun 13, 2019

Fixes #1581. filetypes.Kotlin.conf written by https://github.com/esotericpig.

mime_type=text/x-kotlin

[build-menu]
FT_00_LB=_Compile Kotlin Class

This comment has been minimized.

Copy link
@ntrel

ntrel Jun 13, 2019

Author Member

@esotericpig Are all Kotlin files class files?

This comment has been minimized.

Copy link
@esotericpig

esotericpig Jun 13, 2019

A Kotlin file can contain one class or multiple classes, with ".kt" file extension:

https://kotlinlang.org/docs/reference/coding-conventions.html#source-file-names

A Kotlin script file doesn't need a class at all, with ".kts" file extension.

I guess maybe the text should be changed to "Compile Kotlin File"?

This comment has been minimized.

Copy link
@ntrel

ntrel Jun 13, 2019

Author Member

Thanks. I've changed the menu labels to _Compile, _Execute and Execute _Script - I think this fits better with existing build labels.

@ntrel ntrel referenced this pull request Jun 13, 2019
@ntrel ntrel force-pushed the ntrel:kotlin-ft branch from 0eb3962 to db0aa2f Jun 13, 2019
@ntrel ntrel merged commit 4f76beb into geany:master Jul 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ntrel ntrel deleted the ntrel:kotlin-ft branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.