[filetypes] Update Kotlin basic types #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolik-rce
reviewed
Apr 12, 2023
data/filedefs/filetypes.Kotlin.conf
Outdated
| @@ -4,7 +4,7 @@ | |||
| # https://kotlinlang.org/docs/reference/keyword-reference.html | |||
| primary=abstract assert break case catch class const continue default do else enum extends final finally for goto if implements import instanceof interface native new package private protected public return static strictfp super switch synchronized this throw throws transient try volatile while true false null as fun in object typealias val var when by constructor delegate dynamic field file get init param property receiver set setparam where actual annotation companion const crossinline data expect external infix inline inner internal lateinit noinline open operator out reified sealed suspend tailrec vararg field it | |||
| # https://kotlinlang.org/docs/reference/basic-types.html | |||
| secondary=Double Float Long Int Short Byte NaN Void | |||
| secondary=Boolean Byte Char Double Float Long Int Short String UByte UInt ULong UShort Void | |||
There was a problem hiding this comment.
I'd maybe ditch Void too, it's only used in Java IIRC.
What about Nothing and Unit? Those are kind of basic types too, aren't they? But the link above doesn't mention them, so it is kind of gray area.
Otherwise it looks fine to me (as a Kotlin user).
There was a problem hiding this comment.
Thanks, now done. Also added Any.
|
@dolik-rce fine by you? If so, let's merge. |
|
Yes, you can merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove NaN as it is just a property of floating-point types, it's not a reserved word:
https://github.com/JetBrains/kotlin/blob/30788566012c571aa1d3590912468d1ebe59983d/core/builtins/native/kotlin/Primitives.kt#L1763